fix(extractor): ignore lines that generate unmarshaling errors

pierrelalanne · pierrelalanne · commit bd2e41aef3ab · 2022-02-01T13:55:15.000+01:00
diff --git a/extractor.go b/extractor.go
@@ -79,10 +79,11 @@ func (fe *FastExtractor) Run(path string, after string) chan *GitFile {
 
 			err := json.Unmarshal(cleanedLine, &gitFile)
 			if err != nil {
+				// If an error occurs, print a warning and do nothing with the line
 				log.Warnln("Error while parsing", string(line), err)
+			} else {
+				fe.ChanGitFiles <- &gitFile
 			}
-
-			fe.ChanGitFiles <- &gitFile
 		}
 
 		log.Infof("finished iterating over files, we have collected %d files\n", num)

Original file line number	Diff line number	Diff line change
`@@ -79,10 +79,11 @@ func (fe FastExtractor) Run(path string, after string) chan GitFile {`
`79`	`79`
`80`	`80`	`err := json.Unmarshal(cleanedLine, &gitFile)`
`81`	`81`	`if err != nil {`
	`82`	`+ // If an error occurs, print a warning and do nothing with the line`
`82`	`83`	`log.Warnln("Error while parsing", string(line), err)`
	`84`	`+ } else {`
	`85`	`+ fe.ChanGitFiles <- &gitFile`
`83`	`86`	`}`
`84`		`-`
`85`		`- fe.ChanGitFiles <- &gitFile`
`86`	`87`	`}`
`87`	`88`
`88`	`89`	`log.Infof("finished iterating over files, we have collected %d files\n", num)`