feat: Improve Properties Resource

Author: GeekMasher

ql/lib/codeql/bicep/frameworks/Microsoft/Cache.qll

@@ -105,7 +105,7 @@ module Cache {
        */
       RedisCacheResource getRedisCacheResource() { result = redisCache }
 
-      string toString() { result = "CacheProperties" }
+      override string toString() { result = "CacheProperties[" + redisCache.getName() + "]" }
     }
 
     /**

ql/lib/codeql/bicep/frameworks/Microsoft/Compute.qll

@@ -81,6 +81,10 @@ module Compute {
        * Returns the OS profile object for the virtual machine.
        */
       Compute::Profiles::OsProfile getOsProfile() { result = this.getProperty("osProfile") }
+
+      override string toString() {
+        result = "VirtualMachinesProperties[" + virtualMachines.getName() + "]"
+      }
     }
 
     /**

ql/lib/codeql/bicep/frameworks/Microsoft/Containers.qll

@@ -151,7 +151,7 @@ module Containers {
        */
       StringLiteral getWorkloadProfileName() { result = this.getProperty("workloadProfileName") }
 
-      string toString() { result = "ContainerProperties" }
+      override string toString() { result = "ContainerProperties" }
     }
 
     /**

ql/lib/codeql/bicep/frameworks/Microsoft/Databases.qll

@@ -243,7 +243,7 @@ module Databases {
     override string databaseType() { result = "arc-sql-managed-instance" }
   }
 
-  class PublicDatabaseResource extends PublicResource {
+  private class PublicDatabaseResource extends PublicResource {
     private DatabaseResource database;
 
     /**
@@ -265,7 +265,7 @@ module Databases {
   /**
    * Represents a database resource with a weak TLS version configuration.
    */
-  class WeakDatabaseTlsVersion extends Cryptography::WeakTlsVersion instanceof DatabaseResource {
+  private class WeakDatabaseTlsVersion extends Cryptography::WeakTlsVersion instanceof DatabaseResource {
     /**
      * Returns the minimalTlsVersion property as a StringLiteral for weak TLS version detection.
      */
@@ -279,7 +279,7 @@ module Databases {
      * Represents the properties object for a database resource.
      */
     class Properties extends ResourceProperties {
-      private Resource resource;
+      private DatabaseResource resource;
 
       /**
        * Constructs a Properties object for the given resource.
@@ -290,6 +290,10 @@ module Databases {
        * Returns the underlying resource for these properties.
        */
       Resource getResource() { result = resource }
+
+      override string toString() {
+        result = "DatabaseProperties[" + resource.databaseType() + "]"
+      }
     }
 
     /**

ql/lib/codeql/bicep/frameworks/Microsoft/General.qll

@@ -1,6 +1,10 @@
 private import bicep
 
-abstract class ResourceProperties extends Object {}
+abstract class ResourceProperties extends Object {
+  string toString() {
+    result = super.toString()
+  }
+}
 
 class Sku extends Object {
   private Resource resource;

ql/lib/codeql/bicep/frameworks/Microsoft/KeyVault.qll

@@ -70,7 +70,7 @@ module KeyVault {
      * The properties object for the Microsoft.KeyVault/vaults type.
      * Provides access to Key Vault configuration and settings.
      */
-    class Properties extends Object {
+    class Properties extends ResourceProperties {
       private VaultResource vaultResource;
 
       /**
@@ -189,6 +189,10 @@ module KeyVault {
       AccessPolicy getAccessPolicy(int index) {
         result = this.getProperty("accessPolicies").(Array).getElement(index)
       }
+
+      override string toString() {
+        result = "Key Vault Properties"
+      }
     }
 
     /**

ql/lib/codeql/bicep/frameworks/Microsoft/ManagedContainers.qll

@@ -164,7 +164,7 @@ module ManagedContainers {
        */
       Tags getTags() { result = this.getProperty("tags") }
 
-      string toString() { result = "ManagedContainerProperties" }
+      override string toString() { result = "ManagedContainerProperties" }
     }
 
     /**