Update filekeys and add a test

Author: kevinbackhouse

.github/workflows/basictest.yaml

@@ -0,0 +1,44 @@
+name: Basic test - run the examples to check for errors
+
+on:
+  pull_request
+
+permissions:
+  contents: read
+
+jobs:
+  Linux:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup Python
+        uses: actions/setup-python@v5
+
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Python venv
+        run: |
+          python -m venv .venv
+          source .venv/bin/activate
+          python -m pip install -r requirements.txt
+
+      - name: Run tests
+        env:
+          COPILOT_TOKEN: ${{ secrets.COPILOT_TOKEN }}
+        run: |
+          python main.py -p GitHubSecurityLab/seclab-taskflow-agent/personalities/assistant 'explain modems to me please'
+          python main.py -p GitHubSecurityLab/seclab-taskflow-agent/personalities/c_auditer 'explain modems to me please'
+          python main.py -p GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/echo 'explain modems to me please'
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/CVE-2023-2283/CVE-2023-2283
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/echo
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_globals
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_inputs
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_large_list_result_iter
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_repeat_prompt
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_repeat_prompt_async
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_repeat_prompt_dictionary
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_reusable_prompt
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_reusable_taskflows
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/example_triage_taskflow
+          python main.py -t GitHubSecurityLab/seclab-taskflow-agent/taskflows/examples/single_step_taskflow

main.py

@@ -24,7 +24,7 @@
 from typing import Any
 
 from shell_utils import shell_tool_call
-from mcp_utils import DEFAULT_MCP_CLIENT_SESSION_TIMEOUT, ReconnectingMCPServerStdio, AsyncDebugMCPServerStdio, MCPNamespaceWrap, mcp_client_params, mcp_system_prompt, StreamableMCPThread
+from mcp_utils import DEFAULT_MCP_CLIENT_SESSION_TIMEOUT, ReconnectingMCPServerStdio, AsyncDebugMCPServerStdio, MCPNamespaceWrap, mcp_client_params, mcp_system_prompt, StreamableMCPThread, compress_name
 from render_utils import render_model_output, flush_async_output
 from env_utils import TmpEnv
 from yaml_parser import YamlParser
@@ -256,7 +256,7 @@ async def mcp_session_task(
         for handoff_agent in list(agents.keys())[1:]:
             handoffs.append(TaskAgent(
                 # XXX: name has to be descriptive for an effective handoff
-                name=handoff_agent,
+                name=compress_name(handoff_agent),
                 instructions=prompt_with_handoff_instructions(
                     mcp_system_prompt(
                         agents[handoff_agent]['personality'],
@@ -400,7 +400,7 @@ async def on_handoff_hook(
     if p:
         personality = available_tools.personalities.get(p)
         if personality is None:
-            raise ValueError("No such personality!")
+            raise ValueError(f"No such personality: {p}")
 
         await deploy_task_agents(
             available_tools,
@@ -414,7 +414,7 @@ async def on_handoff_hook(
 
         taskflow = available_tools.taskflows.get(t)
         if taskflow is None:
-            raise ValueError("No such taskflow!")
+            raise ValueError(f"No such taskflow: {t}")
 
         await render_model_output(f"** 🤖💪 Running Task Flow: {t}\n")
 

mcp_utils.py

@@ -9,6 +9,7 @@
 import os
 import socket
 import signal
+import hashlib
 from urllib.parse import urlparse
 
 from mcp.types import CallToolResult, TextContent
@@ -18,6 +19,16 @@
 
 DEFAULT_MCP_CLIENT_SESSION_TIMEOUT = 120
 
+# The openai API complains if the name of a tool is longer than 64
+# chars. But we're encouraging people to use long descriptive
+# filekeys to avoid accidental collisions, so it's very easy to go
+# over the limit. So this function converts a name to a 12 character
+# hash.
+def compress_name(name):
+    m = hashlib.sha256()
+    m.update(name.encode('utf-8'))
+    return m.hexdigest()[:12]
+
 # A process management class for running in-process MCP streamable servers
 class StreamableMCPThread(Thread):
     """Process management for local streamable MCP servers"""
@@ -221,7 +232,7 @@ class MCPNamespaceWrap:
     def __init__(self, confirms, obj):
         self.confirms = confirms
         self._obj = obj
-        self.namespace = f"{obj.name.upper().replace(' ', '_').replace('/','-')}_"
+        self.namespace = compress_name(obj.name)
 
     def __getattr__(self, name):
         attr = getattr(self._obj, name)

personalities/assistant.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/assistant.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/assistant
 
 personality: |
   You are a helpful assistant.

personalities/c_auditer.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/c_auditer.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/c_auditer
 
 personality: |
   Your name is Ronald. You are a C programming language security expert.
@@ -15,5 +15,5 @@ task: |
   your findings where possible.
 
 toolboxes:
-  - toolboxes/memcache.yaml
-  - toolboxes/codeql.yaml
+  - GitHubSecurityLab/seclab-taskflow-agent/toolboxes/memcache
+  - GitHubSecurityLab/seclab-taskflow-agent/toolboxes/codeql

personalities/examples/apple_expert.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/examples/apple_expert.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/apple_expert
 
 personality: |
   You are an apples expert.

personalities/examples/banana_expert.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/examples/banana_expert.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/banana_expert
 
 personality: |
   You are a bananas expert.

personalities/examples/echo.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/examples/echo.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/echo
 
 personality: |
   You are a simple echo bot. You use echo tools to echo things.
@@ -10,5 +10,5 @@ task: |
   Echo user inputs using the echo tools.
   
 toolboxes:
-  - toolboxes/echo.yaml
+  - GitHubSecurityLab/seclab-taskflow-agent/toolboxes/echo
 

personalities/examples/example_triage_agent.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/examples/example_triage_agent.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/example_triage_agent
 
 personality: |
   You are a triage agent. You route tasks to other agents.

personalities/examples/fruit_expert.yaml

@@ -1,7 +1,7 @@
 seclab-taskflow-agent:
   version: 1
   filetype: personality
-  filekey: personalities/examples/fruit_expert.yaml
+  filekey: GitHubSecurityLab/seclab-taskflow-agent/personalities/examples/fruit_expert
 
 personality: |
   Your name is Bob. You are a fruit expert.