Skip to content

Commit 049dba3

Browse files
committed
Use OptionsResolver in Groups::members
1 parent f338fc8 commit 049dba3

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

UPGRADE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ See [documentation](doc/customize.md) to know how to customize the client timeou
2323
* The `visibility_level` parameter have been removed from `create` method. Use `visibility` instead.
2424
* The `all` method now take a single argument which is an associative array of query string parameters.
2525
* The `search` method have been removed. Use `all` method instead.
26+
* The `members` method second and subsequent arguments have been replaced by a single associative array of query string parameters.
2627

2728
## `Gitlab\Api\Issues` changes
2829

lib/Gitlab/Api/Groups.php

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,17 +107,20 @@ public function transfer($group_id, $project_id)
107107
}
108108

109109
/**
110-
* @param int $id
111-
* @param int $page
112-
* @param int $per_page
110+
* @param int $id
111+
* @param array $parameters (
112+
*
113+
* @var string $query A query string to search for members.
114+
* )
115+
*
113116
* @return mixed
114117
*/
115-
public function members($id, $page = 1, $per_page = self::PER_PAGE)
118+
public function members($id, array $parameters = [])
116119
{
117-
return $this->get('groups/'.$this->encodePath($id).'/members', array(
118-
'page' => $page,
119-
'per_page' => $per_page
120-
));
120+
$resolver = $this->createOptionsResolver();
121+
$resolver->setDefined('query');
122+
123+
return $this->get('groups/'.$this->encodePath($id).'/members', $resolver->resolve($parameters));
121124
}
122125

123126
/**

0 commit comments

Comments
 (0)