Skip to content

Commit 0a8a83f

Browse files
author
Daniel André Eikeland
committed
use OptionsResolver to resolve create() parameters
1 parent e36c084 commit 0a8a83f

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

lib/Gitlab/Api/Environments.php

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php namespace Gitlab\Api;
22

3+
use Symfony\Component\OptionsResolver\OptionsResolver;
4+
35
class Environments extends AbstractApi
46
{
57
/**
@@ -13,12 +15,20 @@ public function all($project_id)
1315

1416
/**
1517
* @param int $project_id
16-
* @param array $params
18+
* @param array $parameters
1719
* @return mixed
1820
*/
19-
public function create($project_id, array $params = array())
21+
public function create($project_id, array $parameters = array())
2022
{
21-
return $this->post($this->getProjectPath($project_id, 'environment'), $params);
23+
$resolver = new OptionsResolver();
24+
$resolver->setDefined('name')
25+
->setAllowedTypes('name', 'string');
26+
$resolver->setDefined('slug')
27+
->setAllowedTypes('slug', 'string');
28+
$resolver->setDefined('external_url')
29+
->setAllowedTypes('external_url', 'string');
30+
31+
return $this->post($this->getProjectPath($project_id, 'environment'), $resolver->resolve($parameters));
2232
}
2333

2434
/**

0 commit comments

Comments
 (0)