use OptionsResolver in IssueBoards api

Author: fbourigault

UPGRADE.md

@@ -27,6 +27,10 @@ See [documentation](doc/customize.md) to know how to customize the client timeou
 * The second argument of `update`, `remove`, `showComments`, `showComment`, `addComment`, `updateComment`, `removeComment`,
  `setTimeEstimate`, `resetTimeEstimate`, `addSpentTime` and `resetSpentTime` methods is now a scoped issue id (iid).
 
+## `Gitlab\Api\IssueBoards` changes
+
+* The `all` method second and subsequent arguments have been replaced by a single associative array of query string parameters.
+
 ## `Gitlab\Api\MergeRequests` changes
 
 * The `getList`, `getByIid`, `merged`, `opened` and `closed` methods have been removed. Use `all` method instead.

lib/Gitlab/Api/IssueBoards.php

@@ -4,21 +4,17 @@ class IssueBoards extends AbstractApi
 {
     /**
      * @param int $project_id
-     * @param int $page
-     * @param int $per_page
-     * @param array $params
+     * @param array $parameters
+     *
      * @return mixed
      */
-    public function all($project_id = null, $page = 1, $per_page = self::PER_PAGE, array $params = array())
+    public function all($project_id = null, array $parameters = [])
     {
-        $path = $project_id === null ? 'boards' : $this->getProjectPath($project_id, 'boards');
+        $resolver = $this->createOptionsResolver();
 
-        $params = array_merge(array(
-            'page' => $page,
-            'per_page' => $per_page
-        ), $params);
+        $path = $project_id === null ? 'boards' : $this->getProjectPath($project_id, 'boards');
 
-        return $this->get($path, $params);
+        return $this->get($path, $resolver->resolve($parameters));
     }
 
     /**

test/Gitlab/Tests/Api/IssueBoardsTest.php

@@ -1,7 +1,5 @@
 <?php namespace Gitlab\Tests\Api;
 
-use Gitlab\Api\AbstractApi;
-
 class IssueBoardsTest extends TestCase
 {
     /**
@@ -17,7 +15,7 @@ public function shouldGetAllBoards()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('boards', array('page' => 1, 'per_page' => AbstractApi::PER_PAGE))
+            ->with('boards', array())
             ->will($this->returnValue($expectedArray))
         ;