Skip to content

Commit 5dfe355

Browse files
stas17m1guelpf
authored andcommitted
add tests
1 parent 461258f commit 5dfe355

File tree

3 files changed

+343
-2
lines changed

3 files changed

+343
-2
lines changed

.idea/workspace.xml

Lines changed: 326 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/Gitlab/HttpClient/Message/QueryStringBuilder.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,14 @@ public static function build($query)
1717
if (!is_array($query)) {
1818
return static::rawurlencode($query);
1919
}
20-
return implode('&', array_map(function ($value, $key) {
20+
$query = array_filter($query, function ($value) {
2121
if (null === $value) {
22-
return null;
22+
return false;
2323
}
24+
return true;
25+
});
26+
27+
return implode('&', array_map(function ($value, $key) {
2428
return static::encode($value, $key);
2529
}, $query, array_keys($query)));
2630
}

test/Gitlab/Tests/HttpClient/Message/QueryStringBuilderTest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,17 @@ public function queryStringProvider()
4040
'iids%5B0%5D=88&iids%5B2%5D=86'
4141
];
4242

43+
yield [
44+
[
45+
'source_branch' => 'test_source',
46+
'target_branch' => 'test_master',
47+
'title' => 'test',
48+
'assignee_id' => null,
49+
'target_project_id' => null,
50+
'description' => null
51+
],
52+
];
53+
4354
//Boolean encoding
4455
yield [
4556
['push_events' => false, 'merge_requests_events' => 1],

0 commit comments

Comments
 (0)