Merge branch '10.0' into 10.1

Author: GrahamCampbell

.styleci.yml

@@ -7,6 +7,7 @@ enabled:
   - alpha_ordered_imports
   - array_indentation
   - const_visibility_required
+  - declare_strict_types
   - native_constant_invocation
   - native_function_invocation
   - phpdoc_order

CHANGELOG.md

@@ -7,6 +7,13 @@ CHANGE LOG
 * Added method to get protected branches for a project
 
 
+## 10.0.1 (24/10/2020)
+
+* Fixed using the name of a group as an ID
+* Fixed various phpdoc issues
+* Reverted query builder changes
+
+
 ## 10.0.0 (15/08/2020)
 
 * Added void return types to void methods

tests/ClientTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Gitlab\Tests;
 
 use Gitlab\Client;

tests/HttpClient/Util/QueryStringBuilderTest.php

@@ -0,0 +1,103 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Gitlab\Tests\HttpClient\Util;
+
+use Gitlab\HttpClient\Util\QueryStringBuilder;
+use PHPUnit\Framework\TestCase;
+
+class QueryStringBuilderTest extends TestCase
+{
+    /**
+     * @dataProvider queryStringProvider
+     *
+     * @param mixed  $query
+     * @param string $expected
+     */
+    public function testBuild($query, string $expected): void
+    {
+        $this->assertSame($expected, QueryStringBuilder::build($query));
+    }
+
+    public function queryStringProvider()
+    {
+        //Scalar value.
+        yield [
+            'a project',
+            'a%20project',
+        ];
+
+        //Indexed array.
+        yield [
+            ['iids' => [88, 86]],
+            //iids[]=88&iids[]=86
+            'iids%5B%5D=88&iids%5B%5D=86',
+        ];
+
+        //Non indexed array with only numeric keys.
+        yield [
+            ['iids' => [0 => 88, 2 => 86]],
+            //iids[0]=88&iids[2]=86
+            'iids%5B0%5D=88&iids%5B2%5D=86',
+        ];
+
+        yield [
+            [
+                'source_branch' => 'test_source',
+                'target_branch' => 'test_master',
+                'title' => 'test',
+            ],
+            'source_branch=test_source&target_branch=test_master&title=test',
+        ];
+
+        //Boolean encoding
+        yield [
+            ['push_events' => false, 'merge_requests_events' => 1],
+            'push_events=0&merge_requests_events=1',
+        ];
+
+        //A deeply nested array.
+        yield [
+            [
+                'search' => 'a project',
+                'owned' => 'true',
+                'iids' => [88, 86],
+                'assoc' => [
+                    'a' => 'b',
+                    'c' => [
+                        'd' => 'e',
+                        'f' => 'g',
+                    ],
+                ],
+                'nested' => [
+                    'a' => [
+                        [
+                            'b' => 'c',
+                        ],
+                        [
+                            'd' => 'e',
+                            'f' => [
+                                'g' => 'h',
+                                'i' => 'j',
+                                'k' => [87, 89],
+                            ],
+                        ],
+                    ],
+                ],
+            ],
+            //search=a project
+            //&owned=true
+            //&iids[]=88&iids[]=86
+            //&assoc[a]=b&assoc[c][d]=e&assoc[c][f]=g
+            //&nested[a][][b]=c&nested[a][][d]=e
+            //&nested[a][][f][g]=h&nested[a][][f][i]=j
+            //&nested[a][][f][k][]=87&nested[a][][f][k][]=89
+            'search=a%20project&owned=true&iids%5B%5D=88&iids%5B%5D=86'.
+            '&assoc%5Ba%5D=b&assoc%5Bc%5D%5Bd%5D=e&assoc%5Bc%5D%5Bf%5D=g'.
+            '&nested%5Ba%5D%5B%5D%5Bb%5D=c&nested%5Ba%5D%5B%5D%5Bd%5D=e'.
+            '&nested%5Ba%5D%5B%5D%5Bf%5D%5Bg%5D=h&nested%5Ba%5D%5B%5D%5Bf%5D%5Bi%5D=j'.
+            '&nested%5Ba%5D%5B%5D%5Bf%5D%5Bk%5D%5B%5D=87&nested%5Ba%5D%5B%5D%5Bf%5D%5Bk%5D%5B%5D=89',
+        ];
+    }
+}

tests/IntegrationTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Gitlab\Tests;
 
 use Gitlab\Client;