Update parameters for repository/commits api (#502)

Co-authored-by: Graham Campbell <[email protected]>

Author: glensc

lib/Gitlab/Api/Repositories.php

@@ -168,6 +168,8 @@ public function releases($project_id)
     }
 
     /**
+     * @see https://docs.gitlab.com/ee/api/commits.html#list-repository-commits
+     *
      * @param int|string $project_id
      * @param array      $parameters {
      *
@@ -184,6 +186,9 @@ public function commits($project_id, array $parameters = [])
         $datetimeNormalizer = function (Options $options, \DateTimeInterface $value) {
             return $value->format('c');
         };
+        $booleanNormalizer = function (Options $resolver, $value) {
+            return $value ? 'true' : 'false';
+        };
 
         $resolver->setDefined('path');
         $resolver->setDefined('ref_name');
@@ -195,8 +200,21 @@ public function commits($project_id, array $parameters = [])
             ->setAllowedTypes('until', \DateTimeInterface::class)
             ->setNormalizer('until', $datetimeNormalizer)
         ;
-        $resolver->setDefined('all');
-        $resolver->setDefined('with_stats');
+        $resolver->setDefined('all')
+            ->setAllowedTypes('all', 'bool')
+            ->setNormalizer('all', $booleanNormalizer)
+        ;
+        $resolver->setDefined('with_stats')
+            ->setAllowedTypes('with_stats', 'bool')
+            ->setNormalizer('with_stats', $booleanNormalizer)
+        ;
+        $resolver->setDefined('first_parent')
+            ->setAllowedTypes('first_parent', 'bool')
+            ->setNormalizer('first_parent', $booleanNormalizer)
+        ;
+        $resolver->setDefined('order')
+            ->setAllowedTypes('order', ['default', 'topo'])
+        ;
 
         return $this->get($this->getProjectPath($project_id, 'repository/commits'), $resolver->resolve($parameters));
     }

test/Gitlab/Tests/Api/RepositoriesTest.php

@@ -277,7 +277,7 @@ public function shouldGetCommitsWithParams()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with('projects/1/repository/commits', ['page' => 2, 'per_page' => 25, 'ref_name' => 'master', 'all' => true, 'with_stats' => true, 'path' => 'file_path/file_name'])
+            ->with('projects/1/repository/commits', ['page' => 2, 'per_page' => 25, 'ref_name' => 'master', 'all' => 'true', 'with_stats' => 'true', 'path' => 'file_path/file_name'])
             ->will($this->returnValue($expectedArray))
         ;