Add method to update group variable

Author: jdecool

lib/Gitlab/Api/Groups.php

@@ -264,6 +264,27 @@ public function addVariable($group_id, $key, $value, $protected = null)
         return $this->post($this->getGroupPath($group_id, 'variables'), $payload);
     }
 
+    /**
+     * @param int $group_id
+     * @param string $key
+     * @param string $value
+     * @param bool $protected
+     *
+     * @return mixed
+     */
+    public function updateVariable($group_id, $key, $value, $protected = null)
+    {
+        $payload = array(
+            'value' => $value,
+        );
+
+        if ($protected) {
+            $payload['protected'] = $protected;
+        }
+
+        return $this->put($this->getGroupPath($group_id, 'variables/'.$this->encodePath($key)), $payload);
+    }
+
     private function getGroupSearchResolver()
     {
         $resolver = $this->createOptionsResolver();

test/Gitlab/Tests/Api/GroupsTest.php

@@ -369,6 +369,50 @@ public function shouldAddVariableWithProtected()
         $this->assertEquals($expectedArray, $api->addVariable(1, 'DEPLOY_SERVER', 'stage.example.com', true));
     }
 
+    /**
+     * @test
+     */
+    public function shouldUpdateVariable()
+    {
+        $expectedKey   = 'ftp_port';
+        $expectedValue = '22';
+
+        $expectedArray = array(
+            'key'   => 'ftp_port',
+            'value' => '22',
+        );
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('put')
+            ->with('groups/1/variables/'.$expectedKey, array('value' => $expectedValue))
+            ->will($this->returnValue($expectedArray))
+        ;
+
+        $this->assertEquals($expectedArray, $api->updateVariable(1, $expectedKey, $expectedValue));
+    }
+
+    /**
+     * @test
+     */
+    public function shouldUpdateVariableWithProtected()
+    {
+        $expectedArray = array(
+            'key'   => 'DEPLOY_SERVER',
+            'value' => 'stage.example.com',
+            'protected' => true,
+        );
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('put')
+            ->with('groups/1/variables/DEPLOY_SERVER', array('value' => 'stage.example.com', 'protected' => true))
+            ->will($this->returnValue($expectedArray))
+        ;
+
+        $this->assertEquals($expectedArray, $api->updateVariable(1, 'DEPLOY_SERVER', 'stage.example.com', true));
+    }
+
     protected function getApiClass()
     {
         return 'Gitlab\Api\Groups';