Restored 9.x behaviour for empty JSON responses

GrahamCampbell · GrahamCampbell · commit 8dc7931ef3b2 · 2020-07-23T13:10:02.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@ CHANGE LOG
 ==========
 
 
+## 10.0.0-RC2 (UPCOMING)
+
+* Restored 9.x behaviour for empty JSON responses
+
+
 ## 10.0.0-RC1 (22/07/2020)
 
 * Removed all deprecated functionality
diff --git a/src/HttpClient/Message/ResponseMediator.php b/src/HttpClient/Message/ResponseMediator.php
@@ -45,7 +45,7 @@ public static function getContent(ResponseInterface $response)
     {
         $body = (string) $response->getBody();
 
-        if (0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {
+        if ('' !== $body && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {
             return JsonArray::decode($body);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static function getContent(ResponseInterface $response)`
`45`	`45`	`{`
`46`	`46`	`$body = (string) $response->getBody();`
`47`	`47`
`48`		`- if (0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {`
	`48`	`+ if ('' !== $body && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {`
`49`	`49`	`return JsonArray::decode($body);`
`50`	`50`	`}`
`51`	`51`