Discard null, true, and false responses too

GrahamCampbell · GrahamCampbell · commit 9af481d0e93a · 2020-12-04T01:22:37.000Z
diff --git a/src/HttpClient/Message/ResponseMediator.php b/src/HttpClient/Message/ResponseMediator.php
@@ -45,7 +45,7 @@ public static function getContent(ResponseInterface $response)
     {
         $body = (string) $response->getBody();
 
-        if ('' !== $body && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {
+        if (in_array($body, ['', 'null', 'true', 'false'], true) && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {
             return JsonArray::decode($body);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static function getContent(ResponseInterface $response)`
`45`	`45`	`{`
`46`	`46`	`$body = (string) $response->getBody();`
`47`	`47`
`48`		`- if ('' !== $body && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {`
	`48`	`+ if (in_array($body, ['', 'null', 'true', 'false'], true) && 0 === \strpos($response->getHeaderLine('Content-Type'), self::JSON_CONTENT_TYPE)) {`
`49`	`49`	`return JsonArray::decode($body);`
`50`	`50`	`}`
`51`	`51`