Skip to content

Commit c57c6e5

Browse files
committed
Removed Issue::remove() as is deprecated + some tidy ups
1 parent d7cb4ea commit c57c6e5

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

lib/Gitlab/Api/Issues.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ public function update($project_id, $issue_id, array $params)
2929
return $this->put('projects/'.urlencode($project_id).'/issues/'.urlencode($issue_id), $params);
3030
}
3131

32-
public function remove($project_id, $issue_id)
33-
{
34-
return $this->delete('projects/'.urlencode($project_id).'/issues/'.urlencode($issue_id));
35-
}
36-
3732
public function addComment($project_id, $issue_id, array $params)
3833
{
3934
return $this->post('projects/'.urlencode($project_id).'/issues/'.urlencode($issue_id).'/notes', $params);

lib/Gitlab/Model/Issue.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ public function close($comment = null)
7070
));
7171
}
7272

73-
public function remove()
73+
public function open()
7474
{
75-
$this->api('issues')->remove($this->project->id, $this->id);
76-
77-
return true;
75+
return $this->update(array(
76+
'state_event' => 'reopen'
77+
));
7878
}
7979

8080
public function addComment($body)

lib/Gitlab/Model/Project.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -348,11 +348,18 @@ public function updateIssue($id, array $params)
348348
return $issue->update($params);
349349
}
350350

351-
public function removeIssue($id)
351+
public function closeIssue($id, $comment = null)
352352
{
353353
$issue = new Issue($this, $id, $this->getClient());
354354

355-
return $issue->remove();
355+
return $issue->close($comment);
356+
}
357+
358+
public function openIssue($id)
359+
{
360+
$issue = new Issue($this, $id, $this->getClient());
361+
362+
return $issue->open();
356363
}
357364

358365
public function milestones($page = 1, $per_page = Api::PER_PAGE)

0 commit comments

Comments
 (0)