Skip to content

Commit 4bf9531

Browse files
committed
Code inspection cleanup
1 parent b5614d3 commit 4bf9531

File tree

64 files changed

+200
-221
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+200
-221
lines changed

firebase-analytics/src/androidInstrumentedTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ package dev.gitlive.firebase.analytics
88

99
import androidx.test.platform.app.InstrumentationRegistry
1010

11-
actual val emulatorHost: String = "10.0.2.2"
12-
1311
actual val context: Any = InstrumentationRegistry.getInstrumentation().targetContext
1412

1513
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION)

firebase-analytics/src/androidUnitTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ package dev.gitlive.firebase.analytics
22

33
import org.junit.Ignore
44

5-
actual val emulatorHost: String = "10.0.2.2"
6-
75
actual val context: Any = ""
86

97
actual typealias IgnoreForAndroidUnitTest = Ignore

firebase-analytics/src/commonMain/kotlin/dev/gitlive/firebase/analytics/AnalyticEventConstants.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("UnusedReceiverParameter")
2+
13
package dev.gitlive.firebase.analytics
24

35
public val FirebaseAnalytics.Event: FirebaseAnalyticsEvents

firebase-analytics/src/commonTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import kotlin.test.BeforeTest
1414
import kotlin.test.Test
1515
import kotlin.test.assertNotNull
1616

17-
expect val emulatorHost: String
1817
expect val context: Any
1918
expect annotation class IgnoreForAndroidUnitTest()
2019

firebase-analytics/src/iosTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
package dev.gitlive.firebase.analytics
66

7-
actual val emulatorHost: String = "127.0.0.1"
8-
97
actual val context: Any = Unit
108

119
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION)

firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ internal fun errorToException(error: dynamic) = (error?.code ?: error?.message ?
9191
when {
9292
else -> {
9393
println("Unknown error code in ${JSON.stringify(error)}")
94-
FirebaseAnalyticsException(code, error)
94+
FirebaseAnalyticsException(code, error.unsafeCast<Throwable>())
9595
}
9696
}
9797
}

firebase-analytics/src/jsMain/kotlin/dev/gitlive/firebase/analytics/externals/analytics.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@file:Suppress("ktlint:standard:property-naming")
1+
@file:Suppress("ktlint:standard:property-naming", "PropertyName")
22
@file:JsModule("firebase/analytics")
33
@file:JsNonModule
44

firebase-analytics/src/jsTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package dev.gitlive.firebase.analytics
22

3-
actual val emulatorHost: String = "10.0.2.2"
4-
53
actual val context: Any = Unit
64

75
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION)

firebase-analytics/src/jvmMain/kotlin/dev/gitlive/firebase/analytics/analytics.jvm.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public actual class FirebaseAnalytics {
2121
public actual fun setDefaultEventParameters(parameters: Map<String, String>) {}
2222
public actual fun logEvent(name: String, parameters: Map<String, Any>?) {}
2323

24-
public actual fun setConsent(consentSettings: Map<FirebaseAnalytics.ConsentType, FirebaseAnalytics.ConsentStatus>) {}
24+
public actual fun setConsent(consentSettings: Map<ConsentType, ConsentStatus>) {}
2525

2626
public actual enum class ConsentType {
2727
AD_PERSONALIZATION,

firebase-analytics/src/jvmTest/kotlin/dev/gitlive/firebase/analytics/analytics.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ package dev.gitlive.firebase.analytics
77

88
import dev.gitlive.firebase.testContext
99

10-
actual val emulatorHost: String = "10.0.2.2"
11-
1210
actual val context: Any = testContext
1311

1412
@Target(AnnotationTarget.CLASS, AnnotationTarget.FUNCTION)

0 commit comments

Comments
 (0)