Skip to content

Commit 50b3b61

Browse files
committed
Initialization fixes
1 parent b8be819 commit 50b3b61

File tree

4 files changed

+18
-17
lines changed
  • firebase-firestore/src

4 files changed

+18
-17
lines changed

firebase-firestore/src/androidMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ actual open class Query(open val android: AndroidQuery) {
308308
awaitClose { listener.remove() }
309309
}
310310

311-
internal actual fun where(field: String, vararg clauses: WhereClause) = Query(
311+
actual fun where(field: String, vararg clauses: WhereClause) = Query(
312312
clauses.fold(android) { query, clause ->
313313
when (clause) {
314314
is WhereClause.ForNullableObject -> {
@@ -340,7 +340,7 @@ actual open class Query(open val android: AndroidQuery) {
340340
}
341341
)
342342

343-
internal actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
343+
actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
344344
clauses.fold(android) { query, clause ->
345345
when (clause) {
346346
is WhereClause.ForNullableObject -> {

firebase-firestore/src/commonMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ expect open class Query {
8787
fun snapshots(includeMetadataChanges: Boolean = false): Flow<QuerySnapshot>
8888
suspend fun get(): QuerySnapshot
8989

90-
internal fun where(field: String, vararg clauses: WhereClause): Query
91-
internal fun where(path: FieldPath, vararg clauses: WhereClause): Query
90+
fun where(field: String, vararg clauses: WhereClause): Query
91+
fun where(path: FieldPath, vararg clauses: WhereClause): Query
9292

9393
internal fun _orderBy(field: String, direction: Direction): Query
9494
internal fun _orderBy(field: FieldPath, direction: Direction): Query
@@ -113,10 +113,12 @@ private val Any.safeValue: Any get() = when (this) {
113113
else -> this
114114
}
115115

116-
fun Query.where(field: String, equalTo: Any?) = where(field, WhereClause.EqualTo(equalTo))
117-
fun Query.where(path: FieldPath, equalTo: Any?) = where(path, WhereClause.EqualTo(equalTo))
118-
fun Query.whereNot(field: String, notEqualTo: Any?) = where(field, WhereClause.NotEqualTo(notEqualTo))
119-
fun Query.whereNot(path: FieldPath, notEqualTo: Any?) = where(path, WhereClause.NotEqualTo(notEqualTo))
116+
fun Query.where(field: String, equalTo: Any?) = where(field, clause = WhereClause.EqualTo(equalTo))
117+
fun Query.where(path: FieldPath, equalTo: Any?) = where(path, clause = WhereClause.EqualTo(equalTo))
118+
fun Query.where(field: String, clause: WhereClause): Query = where(field, clauses = listOf(clause).toTypedArray())
119+
fun Query.where(path: FieldPath, clause: WhereClause): Query = where(path, clauses = listOf(clause).toTypedArray())
120+
fun Query.whereNot(field: String, notEqualTo: Any?) = where(field, clause = WhereClause.NotEqualTo(notEqualTo))
121+
fun Query.whereNot(path: FieldPath, notEqualTo: Any?) = where(path, clause = WhereClause.NotEqualTo(notEqualTo))
120122
fun Query.where(field: String,
121123
lessThan: Any? = null,
122124
greaterThan: Any? = null,
@@ -129,7 +131,7 @@ fun Query.where(field: String,
129131
) =
130132
where(
131133
field,
132-
listOfNotNull(
134+
clauses = listOfNotNull(
133135
lessThan?.let { WhereClause.LessThan(it) },
134136
greaterThan?.let { WhereClause.GreaterThan(it) },
135137
lessThanOrEqualTo?.let { WhereClause.LessThanOrEqualTo(it) },
@@ -138,7 +140,7 @@ fun Query.where(field: String,
138140
arrayContainsAny?.let { WhereClause.ArrayContainsAny(it) },
139141
inArray?.let { WhereClause.InArray(it) },
140142
notInArray?.let { WhereClause.NotInArray(it) }
141-
)
143+
).toTypedArray()
142144
)
143145

144146
fun Query.where(path: FieldPath,
@@ -153,7 +155,7 @@ fun Query.where(path: FieldPath,
153155
) =
154156
where(
155157
path,
156-
listOfNotNull(
158+
clauses = listOfNotNull(
157159
lessThan?.let { WhereClause.LessThan(it) },
158160
greaterThan?.let { WhereClause.GreaterThan(it) },
159161
lessThanOrEqualTo?.let { WhereClause.LessThanOrEqualTo(it) },
@@ -162,10 +164,9 @@ fun Query.where(path: FieldPath,
162164
arrayContainsAny?.let { WhereClause.ArrayContainsAny(it) },
163165
inArray?.let { WhereClause.InArray(it) },
164166
notInArray?.let { WhereClause.NotInArray(it) }
165-
)
167+
).toTypedArray()
166168
)
167169

168-
169170
fun Query.orderBy(field: String, direction: Direction = Direction.ASCENDING) = _orderBy(field, direction)
170171
fun Query.orderBy(field: FieldPath, direction: Direction = Direction.ASCENDING) = _orderBy(field, direction)
171172

firebase-firestore/src/iosMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ actual open class Query(open val ios: FIRQuery) {
272272
awaitClose { listener.remove() }
273273
}
274274

275-
internal actual fun where(field: String, vararg clauses: WhereClause) = Query(
275+
actual fun where(field: String, vararg clauses: WhereClause) = Query(
276276
clauses.fold(ios) { query, clause ->
277277
when (clause) {
278278
is WhereClause.EqualTo -> query.queryWhereField(field, isEqualTo = clause.safeValue ?: NSNull)
@@ -289,7 +289,7 @@ actual open class Query(open val ios: FIRQuery) {
289289
}
290290
)
291291

292-
internal actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
292+
actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
293293
clauses.fold(ios) { query, clause ->
294294
when (clause) {
295295
is WhereClause.EqualTo -> query.queryWhereFieldPath(path.ios, isEqualTo = clause.safeValue ?: NSNull)

firebase-firestore/src/jsMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ actual open class Query(open val js: JsQuery) {
293293

294294
actual fun limit(limit: Number) = Query(query(js, jsLimit(limit)))
295295

296-
internal actual fun where(field: String, vararg clauses: WhereClause) = Query(
296+
actual fun where(field: String, vararg clauses: WhereClause) = Query(
297297
clauses.fold(js) { query, clause ->
298298
val value = when (clause) {
299299
is WhereClause.ForNullableObject -> clause.safeValue
@@ -303,7 +303,7 @@ actual open class Query(open val js: JsQuery) {
303303
query(query, jsWhere(field, clause.filterOp, value))
304304
}
305305
)
306-
internal actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
306+
actual fun where(path: FieldPath, vararg clauses: WhereClause) = Query(
307307
clauses.fold(js) { query, clause ->
308308
val value = when (clause) {
309309
is WhereClause.ForNullableObject -> clause.safeValue

0 commit comments

Comments
 (0)