Skip to content

Commit 636eade

Browse files
authored
Merge pull request #446 from MattSkala/ci/wait-on-emulator
Wait for emulator to start
2 parents eb56044 + e06ca79 commit 636eade

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/actions/setup_test_action/action.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ runs:
2424
run: chmod +x gradlew
2525
- name: Install Firebase tools
2626
shell: bash
27-
run: npm install -g firebase-tools
27+
run: npm install -g firebase-tools wait-on
2828
- name: Start Firebase emulator
2929
shell: bash
30-
run: "firebase emulators:start --config=./test/firebase.json &"
30+
run: |
31+
firebase emulators:start --config=./test/firebase.json &
32+
wait-on http://127.0.0.1:9099

.github/workflows/pull_request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ jobs:
6666
- uses: actions/checkout@v3
6767
- name: Setup test environment
6868
uses: ./.github/actions/setup_test_action
69+
timeout-minutes: 10
6970
- name: Run JS Tests
7071
run: ./gradlew cleanTest jsTest
7172
- name: Upload JS test artifact
@@ -89,14 +90,13 @@ jobs:
8990
- uses: actions/checkout@v3
9091
- name: Cocoapods cache
9192
uses: actions/cache@v3
92-
id: cocoapods-cache
9393
with:
9494
path: |
9595
~/.cocoapods
9696
~/Library/Caches/CocoaPods
9797
*/build/cocoapods
9898
*/build/classes
99-
key: cocoapods-cache
99+
key: cocoapods-cache-v2
100100
- name: Setup test environment
101101
uses: ./.github/actions/setup_test_action
102102
- name: Run iOS Tests
@@ -112,4 +112,4 @@ jobs:
112112
if: failure()
113113
with:
114114
name: "Firebase Debug Log"
115-
path: "**/firebase-debug.log"
115+
path: "**/firebase-debug.log"

0 commit comments

Comments
 (0)