Fixes to fix CI + cleanup

Author: Daeda88

.gitignore

@@ -9,6 +9,5 @@ Firebase*.zip
 /Firebase
 .DS_Store
 *.log
-
 /kotlin-js-store/
 /kotlin-js-store/yarn.lock

firebase-app/build.gradle.kts

@@ -10,11 +10,6 @@ plugins {
     kotlin("multiplatform")
 }
 
-repositories {
-    google()
-    mavenCentral()
-}
-
 android {
     val minSdkVersion: Int by project
     val compileSdkVersion: Int by project

firebase-auth/build.gradle.kts

@@ -11,16 +11,6 @@ plugins {
     //id("com.quittle.android-emulator") version "0.2.0"
 }
 
-//buildscript {
-//    repositories {
-//        google()
-//        gradlePluginPortal()
-//    }
-//    dependencies {
-//        classpath("com.android.tools.build:gradle:3.6.1")
-//    }
-//}
-
 android {
     val minSdkVersion: Int by project
     val compileSdkVersion: Int by project

firebase-auth/src/androidMain/kotlin/dev/gitlive/firebase/auth/user.kt

@@ -8,16 +8,16 @@ import android.net.Uri
 import com.google.firebase.auth.UserProfileChangeRequest
 import kotlinx.coroutines.tasks.await
 
-actual class FirebaseUser internal constructor(val android: com.google.firebase.auth.FirebaseUser) {
+actual class FirebaseUser internal constructor(val android: com.google.firebase.auth.FirebaseUser) : FirebaseUserProfile {
     actual val uid: String
         get() = android.uid
-    actual val displayName: String?
+    override val displayName: String?
         get() = android.displayName
     actual val email: String?
         get() = android.email
     actual val phoneNumber: String?
         get() = android.phoneNumber
-    actual val photoURL: String?
+    override val photoURL: String?
         get() = android.photoUrl?.toString()
     actual val isAnonymous: Boolean
         get() = android.isAnonymous
@@ -46,7 +46,7 @@ actual class FirebaseUser internal constructor(val android: com.google.firebase.
     actual suspend fun updateEmail(email: String) = android.updateEmail(email).await().run { Unit }
     actual suspend fun updatePassword(password: String) = android.updatePassword(password).await().run { Unit }
     actual suspend fun updatePhoneNumber(credential: PhoneAuthCredential) = android.updatePhoneNumber(credential.android).await().run { Unit }
-    actual suspend fun updateProfile(displayName: String?, photoUrl: String?) {
+    override suspend fun updateProfile(displayName: String?, photoUrl: String?) {
         val request = UserProfileChangeRequest.Builder()
             .setDisplayName(displayName)
             .setPhotoUri(photoUrl?.let { Uri.parse(it) })

firebase-auth/src/commonMain/kotlin/dev/gitlive/firebase/auth/user.kt

@@ -4,12 +4,17 @@
 
 package dev.gitlive.firebase.auth
 
-expect class FirebaseUser {
-    val uid: String
+// Javascript IR compilation has issues with referencing to actual values as default parameters, so we should use an interface instead
+interface FirebaseUserProfile {
     val displayName: String?
+    val photoURL: String?
+    suspend fun updateProfile(displayName: String? = this.displayName, photoUrl: String? = this.photoURL)
+}
+
+expect class FirebaseUser : FirebaseUserProfile {
+    val uid: String
     val email: String?
     val phoneNumber: String?
-    val photoURL: String?
     val isAnonymous: Boolean
     val isEmailVerified: Boolean
     val metaData: UserMetaData?
@@ -28,7 +33,6 @@ expect class FirebaseUser {
     suspend fun updateEmail(email: String)
     suspend fun updatePassword(password: String)
     suspend fun updatePhoneNumber(credential: PhoneAuthCredential)
-    suspend fun updateProfile(displayName: String? = this.displayName, photoUrl: String? = this.photoURL)
     suspend fun verifyBeforeUpdateEmail(newEmail: String, actionCodeSettings: ActionCodeSettings? = null)
 }
 

firebase-auth/src/iosMain/kotlin/dev/gitlive/firebase/auth/user.kt

@@ -7,16 +7,16 @@ package dev.gitlive.firebase.auth
 import cocoapods.FirebaseAuth.*
 import platform.Foundation.NSURL
 
-actual class FirebaseUser internal constructor(val ios: FIRUser) {
+actual class FirebaseUser internal constructor(val ios: FIRUser) : FirebaseUserProfile {
     actual val uid: String
         get() = ios.uid
-    actual val displayName: String?
+    override val displayName: String?
         get() = ios.displayName
     actual val email: String?
         get() = ios.email
     actual val phoneNumber: String?
         get() = ios.phoneNumber
-    actual val photoURL: String?
+    override val photoURL: String?
         get() = ios.photoURL?.absoluteString
     actual val isAnonymous: Boolean
         get() = ios.anonymous
@@ -64,7 +64,7 @@ actual class FirebaseUser internal constructor(val ios: FIRUser) {
     actual suspend fun updateEmail(email: String) = ios.await { updateEmail(email, it) }.run { Unit }
     actual suspend fun updatePassword(password: String) = ios.await { updatePassword(password, it) }.run { Unit }
     actual suspend fun updatePhoneNumber(credential: PhoneAuthCredential) = ios.await { updatePhoneNumberCredential(credential.ios, it) }.run { Unit }
-    actual suspend fun updateProfile(displayName: String?, photoUrl: String?) {
+    override suspend fun updateProfile(displayName: String?, photoUrl: String?) {
         val request = ios.profileChangeRequest().apply {
             this.displayName = displayName
             this.photoURL = photoUrl?.let { NSURL.URLWithString(it) }

firebase-auth/src/jsMain/kotlin/dev/gitlive/firebase/auth/user.kt

@@ -4,16 +4,16 @@ import dev.gitlive.firebase.firebase
 import kotlinx.coroutines.await
 import kotlin.js.Date
 
-actual class FirebaseUser internal constructor(val js: firebase.user.User) {
+actual class FirebaseUser internal constructor(val js: firebase.user.User) : FirebaseUserProfile {
     actual val uid: String
         get() = rethrow { js.uid }
-    actual val displayName: String?
+    override val displayName: String?
         get() = rethrow { js.displayName }
     actual val email: String?
         get() = rethrow { js.email }
     actual val phoneNumber: String?
         get() = rethrow { js.phoneNumber }
-    actual val photoURL: String?
+    override val photoURL: String?
         get() = rethrow { js.photoURL }
     actual val isAnonymous: Boolean
         get() = rethrow { js.isAnonymous }
@@ -43,7 +43,7 @@ actual class FirebaseUser internal constructor(val js: firebase.user.User) {
     actual suspend fun updateEmail(email: String) = rethrow { js.updateEmail(email).await() }
     actual suspend fun updatePassword(password: String) = rethrow { js.updatePassword(password).await() }
     actual suspend fun updatePhoneNumber(credential: PhoneAuthCredential) = rethrow { js.updatePhoneNumber(credential.js).await() }
-    actual suspend fun updateProfile(displayName: String?, photoUrl: String?) = rethrow {
+    override suspend fun updateProfile(displayName: String?, photoUrl: String?) = rethrow {
         val request = object : firebase.user.ProfileUpdateRequest {
             override val displayName: String? = displayName
             override val photoURL: String? = photoUrl
@@ -56,9 +56,9 @@ actual class FirebaseUser internal constructor(val js: firebase.user.User) {
 actual class UserInfo(val js: firebase.user.UserInfo) {
     actual val displayName: String?
         get() = rethrow { js.displayName }
-        actual val email: String?
+    actual val email: String?
         get() = rethrow { js.email }
-        actual val phoneNumber: String?
+    actual val phoneNumber: String?
         get() = rethrow { js.phoneNumber }
     actual val photoURL: String?
         get() = rethrow { js.photoURL }