Skip to content

Commit e23d06d

Browse files
authored
Merge pull request #182 from GitLiveApp/fix_js_tests
fix gradle build task
2 parents f3d4797 + 377df51 commit e23d06d

File tree

11 files changed

+42
-12
lines changed

11 files changed

+42
-12
lines changed

.github/workflows/pull_request.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@ jobs:
3030
run: ./gradlew assemble
3131
- name: Run JS Tests
3232
run: ./gradlew cleanTest jsTest
33+
- name: Upload test artifact
34+
uses: actions/upload-artifact@v2
35+
if: failure()
36+
with:
37+
name: "JSTest Report HTML"
38+
path: "firebase-firestore/build/reports/tests/jsTest/"
3339
- name: Run Android Instrumented Tests
3440
uses: reactivecircus/android-emulator-runner@v2
3541
with:

build.gradle.kts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,16 @@ subprojects {
6767
onlyIf { !project.gradle.startParameter.taskNames.contains("publishToMavenLocal") }
6868
}
6969

70+
tasks.whenTaskAdded {
71+
enabled = when(name) {
72+
"compileDebugUnitTestKotlinAndroid" -> false
73+
"compileReleaseUnitTestKotlinAndroid" -> false
74+
"testDebugUnitTest" -> false
75+
"testReleaseUnitTest" -> false
76+
else -> enabled
77+
}
78+
}
79+
7080
tasks {
7181

7282
val updateVersion by registering(Exec::class) {

firebase-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
2525
"dependencies": {
2626
"@gitlive/firebase-common": "1.2.0",
27-
"firebase": "8.2.10",
27+
"firebase": "8.5.0",
2828
"kotlin": "1.4.31",
2929
"kotlinx-coroutines-core": "1.4.3"
3030
}

firebase-auth/build.gradle.kts

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,20 @@ kotlin {
102102

103103
js {
104104
useCommonJs()
105-
nodejs()
106-
browser()
105+
nodejs {
106+
testTask {
107+
useMocha {
108+
timeout = "5s"
109+
}
110+
}
111+
}
112+
browser {
113+
testTask {
114+
useMocha {
115+
timeout = "5s"
116+
}
117+
}
118+
}
107119
}
108120

109121
sourceSets {

firebase-auth/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
2525
"dependencies": {
2626
"@gitlive/firebase-app": "1.2.0",
27-
"firebase": "8.2.10",
27+
"firebase": "8.5.0",
2828
"kotlin": "1.4.31",
2929
"kotlinx-coroutines-core": "1.4.3"
3030
}

firebase-common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
},
2424
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-multiplatform-sdk",
2525
"dependencies": {
26-
"firebase": "8.2.10",
26+
"firebase": "8.5.0",
2727
"kotlin": "1.4.31",
2828
"kotlinx-coroutines-core": "1.4.3",
2929
"kotlinx-serialization-kotlinx-serialization-runtime": "1.1.0"

firebase-common/src/commonTest/kotlin/dev/gitlive/firebase/EncodersTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class EncodersTest {
5151

5252
@Test
5353
fun decodeObjectNullableValue() {
54-
val decoded = decode(TestData.serializer(), mapOf("map" to mapOf("key" to "value"), "nullableBool" to null))
54+
val decoded = decode(TestData.serializer(), nativeMapOf("map" to mapOf("key" to "value"), "nullableBool" to null))
5555
assertNull(decoded.nullableBool)
5656
}
5757
}

firebase-database/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
2525
"dependencies": {
2626
"@gitlive/firebase-app": "1.2.0",
27-
"firebase": "8.2.10",
27+
"firebase": "8.5.0",
2828
"kotlin": "1.4.31",
2929
"kotlinx-coroutines-core": "1.4.3"
3030
}

firebase-firestore/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-sdk",
2525
"dependencies": {
2626
"@gitlive/firebase-app": "1.2.0",
27-
"firebase": "8.2.10",
27+
"firebase": "8.5.0",
2828
"kotlin": "1.4.31",
2929
"kotlinx-coroutines-core": "1.4.3"
3030
}

firebase-firestore/src/commonTest/kotlin/dev/gitlive/firebase/firestore/firestore.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@ class FirebaseFirestoreTest {
3939
@Test
4040
fun testStringOrderBy() = runTest {
4141
setupFirestoreData()
42-
43-
val resultDocs = Firebase.firestore.collection("FirebaseFirestoreTest")
44-
.orderBy("prop1").get().documents
42+
val resultDocs = Firebase.firestore
43+
.collection("FirebaseFirestoreTest")
44+
.orderBy("prop1")
45+
.get()
46+
.documents
4547
assertEquals(3, resultDocs.size)
4648
assertEquals("aaa", resultDocs[0].get("prop1"))
4749
assertEquals("bbb", resultDocs[1].get("prop1"))

0 commit comments

Comments
 (0)