Skip to content

Commit ec69836

Browse files
Respond to PR comments
1 parent 6ebf5b0 commit ec69836

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,4 +242,4 @@ You can build and test the project locally.
242242
1. Open the project in IntelliJ IDEA.
243243
2. Install cocoapods via `sudo gem install -n /usr/local/bin cocoapods`
244244
3. Install the GitLive plugin into IntelliJ
245-
4. After a gradle sync then run `firebase-storage:publishToMavenLocal`
245+
4. After a gradle sync then run `publishToMavenLocal`

firebase-common/src/jsMain/kotlin/dev/gitlive/firebase/externals.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,7 @@ external object firebase {
518518
fun setMaxOperationRetryTime(time: Double): Unit
519519
fun setMaxUploadRetryTime(time: Double): Unit
520520
fun useEmulator(host: String, port: Int)
521+
fun ref(): Reference
521522
}
522523

523524
open class Reference {

firebase-storage/src/androidMain/kotlin/dev/gitlive/firebase/storage/storage.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ actual class StorageReference(val android: com.google.firebase.storage.StorageRe
9191
}
9292
}
9393

94-
actual class ListResult(val android: com.google.firebase.storage.ListResult) {
95-
actual val prefixes: List<StorageReference> get() = android.prefixes.map { StorageReference(it) }
96-
actual val items: List<StorageReference> get() = android.items.map { StorageReference(it) }
97-
actual val pageToken: String? get() = android.pageToken
94+
actual class ListResult(android: com.google.firebase.storage.ListResult) {
95+
actual val prefixes: List<StorageReference> = android.prefixes.map { StorageReference(it) }
96+
actual val items: List<StorageReference> = android.items.map { StorageReference(it) }
97+
actual val pageToken: String? = android.pageToken
9898
}
9999

100100
actual class File(val uri: Uri)

firebase-storage/src/jsMain/kotlin/dev/gitlive/firebase/storage/storage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ actual class FirebaseStorage(val js: firebase.storage.Storage) {
3838
js.useEmulator(host, port)
3939
}
4040

41-
actual val reference: StorageReference get() = TODO()
41+
actual val reference: StorageReference get() = StorageReference(js.ref())
4242
}
4343

4444
actual class StorageReference(val js: firebase.storage.Reference) {

0 commit comments

Comments
 (0)