Skip to content

Commit fbb34c7

Browse files
committed
Merge branch 'feature/kotlin-2.0' into feature/api-validation
2 parents e337d0a + 9639a5d commit fbb34c7

File tree

5 files changed

+31
-6
lines changed

5 files changed

+31
-6
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ env:
1515

1616
jobs:
1717
build:
18-
runs-on: macos-14
18+
runs-on: macos-latest
1919
steps:
2020
- uses: actions/checkout@v4
2121
- name: Set up JDK

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
name: "Firebase Debug Log"
8383
path: "**/firebase-debug.log"
8484
build-ios:
85-
runs-on: macos-14
85+
runs-on: macos-latest
8686
steps:
8787
- uses: actions/checkout@v4
8888
- name: Cocoapods cache

firebase-crashlytics/src/commonTest/kotlin/dev/gitlive/firebase/crashlytics/crashlytics.kt

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ import dev.gitlive.firebase.apps
1010
import dev.gitlive.firebase.initialize
1111
import dev.gitlive.firebase.runBlockingTest
1212
import dev.gitlive.firebase.runTest
13+
import kotlinx.coroutines.delay
1314
import kotlin.test.AfterTest
1415
import kotlin.test.BeforeTest
1516
import kotlin.test.Test
1617
import kotlin.test.assertFalse
18+
import kotlin.time.Duration.Companion.seconds
1719

1820
expect val emulatorHost: String
1921
expect val context: Any
@@ -51,36 +53,57 @@ class FirebaseCrashlyticsTest {
5153
@Test
5254
fun testRecordException() = runTest {
5355
crashlytics.recordException(Exception("Test Exception"))
56+
57+
// Delay to ensure Crashlytics completes
58+
delay(1.seconds)
5459
}
5560

5661
@Test
5762
fun testLog() = runTest {
5863
crashlytics.log("Test Log")
64+
65+
// Delay to ensure Crashlytics completes
66+
delay(1.seconds)
5967
}
6068

6169
@Test
6270
fun testSetUserId() = runTest {
6371
crashlytics.setUserId("Test User Id")
72+
73+
// Delay to ensure Crashlytics completes
74+
delay(1.seconds)
6475
}
6576

6677
@Test
6778
fun testSendUnsentReports() = runTest {
6879
crashlytics.sendUnsentReports()
80+
81+
// Delay to ensure Crashlytics completes
82+
delay(1.seconds)
6983
}
7084

7185
@Test
7286
fun testDeleteUnsentReports() = runTest {
7387
crashlytics.deleteUnsentReports()
88+
89+
// Delay to ensure Crashlytics completes
90+
delay(1.seconds)
7491
}
7592

7693
@Test
7794
fun testDidCrashOnPreviousExecution() = runTest {
7895
val didCrash = crashlytics.didCrashOnPreviousExecution()
7996
assertFalse { didCrash }
97+
98+
// Delay to ensure Crashlytics completes
99+
delay(1.seconds)
80100
}
81101

82102
@Test
83103
fun testSetCrashlyticsCollectionEnabled() = runTest {
84104
crashlytics.setCrashlyticsCollectionEnabled(true)
105+
106+
// Delay to ensure Crashlytics completes
107+
delay(1.seconds)
85108
}
86109
}

firebase-storage/src/commonTest/kotlin/dev/gitlive/firebase/storage/storage.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import dev.gitlive.firebase.FirebaseOptions
99
import dev.gitlive.firebase.apps
1010
import dev.gitlive.firebase.initialize
1111
import dev.gitlive.firebase.runBlockingTest
12+
import dev.gitlive.firebase.runTest
1213
import kotlin.test.AfterTest
1314
import kotlin.test.BeforeTest
1415
import kotlin.test.Test
@@ -58,14 +59,15 @@ class FirebaseStorageTest {
5859
}
5960

6061
@Test
61-
fun testUploadShouldNotCrash() = runBlockingTest {
62+
fun testUploadShouldNotCrash() = runTest {
6263
val data = createTestData()
6364
val ref = storage.reference("test").child("testUploadShouldNotCrash.txt")
65+
6466
ref.putData(data)
6567
}
6668

6769
@Test
68-
fun testUploadMetadata() = runBlockingTest {
70+
fun testUploadMetadata() = runTest {
6971
val data = createTestData()
7072
val ref = storage.reference("test").child("testUploadMetadata.txt")
7173
val metadata = storageMetadata {
@@ -81,7 +83,7 @@ class FirebaseStorageTest {
8183
}
8284

8385
@Test
84-
fun testUploadCustomMetadata() = runBlockingTest {
86+
fun testUploadCustomMetadata() = runTest {
8587
val data = createTestData()
8688
val ref = storage.reference("test").child("testUploadCustomMetadata.txt")
8789
val metadata = storageMetadata {

firebase-storage/src/iosTest/kotlin/dev/gitlive/firebase/storage/storage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
package dev.gitlive.firebase.storage
66

7-
actual val emulatorHost: String = "127.0.0.1"
7+
actual val emulatorHost: String = "localhost"
88

99
actual val context: Any = Unit
1010

0 commit comments

Comments
 (0)