Skip to content

Potential fix for code scanning alert no. 14: URL redirection from remote source #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Potential fix for code scanning alert no. 14: URL redirection from remote source #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import io
import base64
from datetime import datetime

from urllib.parse import urlparse
auth_bp = Blueprint('auth', __name__)

@auth_bp.route('/login', methods=['GET', 'POST'])
Expand All @@ -32,7 +32,11 @@ def login():
login_user(user)

next_page = request.args.get('next')
return redirect(next_page) if next_page else redirect(url_for('index'))
if next_page:
safe_next = next_page.replace('\\', '')
if not urlparse(safe_next).netloc and not urlparse(safe_next).scheme:
return redirect(safe_next)
return redirect(url_for('index'))
else:
flash('Invalid 2FA code', 'error')
# Show 2FA form again with username preserved
Expand All @@ -54,7 +58,11 @@ def login():
login_user(user)

next_page = request.args.get('next')
return redirect(next_page) if next_page else redirect(url_for('index'))
if next_page:
safe_next = next_page.replace('\\', '')
if not urlparse(safe_next).netloc and not urlparse(safe_next).scheme:
return redirect(safe_next)
return redirect(url_for('index'))
else:
flash('Invalid username or password', 'error')

Expand Down
Loading