Potential fix for code scanning alert no. 2: Information exposure through an exception #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/GitTimeraider/Directadmin-Emailforwarder/security/code-scanning/2
To fix the problem, we should avoid returning the exception message (
str(e)) in the API response. Instead, we should return a generic error message to the client, while logging the detailed error (including the stack trace) on the server for debugging purposes. This ensures that sensitive information is not leaked to the client, but developers can still diagnose issues using the server logs.Specifically, in
app/main.py, in the exception handler for the/api/forwardersGET endpoint (lines 133–140), remove the'details': str(e)field from the JSON response. The server-side logging (printandtraceback.print_exc()) can remain as-is.No new imports or methods are required, as logging is already being done.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.