(maint) Updated according to sonarlint recommendations

Author: AdmiringWorm

Source/GitReleaseManager.Cli/Program.cs

@@ -23,7 +23,6 @@ namespace GitReleaseManager.Cli
     public static class Program
     {
         private static FileSystem _fileSystem;
-        private static Config _configuration;
         private static IMapper _mapper;
         private static IVcsProvider _vcsProvider;
 
@@ -75,7 +74,7 @@ private static void CreateFiglet(BaseSubOptions options)
             }
 
             var version = Assembly.GetEntryAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion;
-            if (version.IndexOf('+') > 0)
+            if (version.IndexOf('+') >= 0)
             {
                 version = version.Substring(0, version.IndexOf('+'));
             }
@@ -223,10 +222,10 @@ private static async Task<int> CreateLabelsAsync(LabelSubOptions subOptions)
 
         private static IVcsProvider GetVcsProvider(BaseVcsOptions subOptions)
         {
-            _configuration = ConfigurationProvider.Provide(subOptions.TargetDirectory ?? Environment.CurrentDirectory, _fileSystem);
+            var configuration = ConfigurationProvider.Provide(subOptions.TargetDirectory ?? Environment.CurrentDirectory, _fileSystem);
 
             Log.Information("Using {Provider} as VCS Provider", "GitHub");
-            return new GitHubProvider(_mapper, _configuration, subOptions.UserName, subOptions.Password, subOptions.Token);
+            return new GitHubProvider(_mapper, configuration, subOptions.UserName, subOptions.Password, subOptions.Token);
         }
 
         private static void LogOptions(BaseSubOptions options)

Source/GitReleaseManager/GitHubProvider.cs

@@ -236,7 +236,7 @@ public async Task AddAssets(string owner, string repository, string tagName, ILi
 
                     var assetFileName = Path.GetFileName(asset);
 
-                    var existingAsset = release.Assets.Where(a => a.Name == assetFileName).FirstOrDefault();
+                    var existingAsset = release.Assets.FirstOrDefault(a => a.Name == assetFileName);
                     if (existingAsset != null)
                     {
                         _logger.Warning("Requested asset to be uploaded already exists on draft release, replacing with new file: {AssetPath}", asset);

Source/GitReleaseManager/ReleaseNotesBuilder.cs

@@ -165,7 +165,7 @@ private Milestone GetPreviousMilestone()
             var currentVersion = _targetMilestone.Version;
             return _milestones
                 .OrderByDescending(m => m.Version)
-                .Distinct().ToList()
+                .Distinct()
                 .SkipWhile(x => x.Version >= currentVersion)
                 .FirstOrDefault();
         }
@@ -176,16 +176,14 @@ private void AddFooter(StringBuilder stringBuilder)
 
             var footerContent = _configuration.Create.FooterContent;
 
-            if (_configuration.Create.FooterIncludesMilestone)
+            if (_configuration.Create.FooterIncludesMilestone
+                && !string.IsNullOrEmpty(_configuration.Create.MilestoneReplaceText))
             {
-                if (!string.IsNullOrEmpty(_configuration.Create.MilestoneReplaceText))
-                {
-                    var replaceValues = new Dictionary<string, object>
+                var replaceValues = new Dictionary<string, object>
                     {
                         { _configuration.Create.MilestoneReplaceText.Trim('{', '}'), _milestoneTitle },
                     };
-                    footerContent = footerContent.ReplaceTemplate(replaceValues);
-                }
+                footerContent = footerContent.ReplaceTemplate(replaceValues);
             }
 
             stringBuilder.Append(footerContent);