(maint) Be consistent about Async suffix

Almost all of the code in GitReleaseManager uses the Async suffix for
methods that return a Task, but there were a couple that wasn't doing
that.

This commit addresses that by making sure that we are consistent
everywhere.

Author: gep13

src/GitReleaseManager.Cli/Program.cs

@@ -192,7 +192,7 @@ private static Task<int> ExecuteCommand<TOptions>(TOptions options)
             where TOptions : BaseSubOptions
         {
             var command = _serviceProvider.GetRequiredService<ICommand<TOptions>>();
-            return command.Execute(options);
+            return command.ExecuteAsync(options);
         }
 
         private static void LogOptions(BaseSubOptions options)

src/GitReleaseManager.Core.Tests/Commands/AddAssetsCommandTests.cs

@@ -38,7 +38,7 @@ public async Task Should_Execute_Command()
             _vcsService.AddAssetsAsync(options.RepositoryOwner, options.RepositoryName, options.TagName, options.AssetPaths).
                 Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).AddAssetsAsync(options.RepositoryOwner, options.RepositoryName, options.TagName, options.AssetPaths).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/CloseCommandTests.cs

@@ -36,7 +36,7 @@ public async Task Should_Execute_Command()
             _vcsService.CloseMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone)
                 .Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).CloseMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/CreateCommandTests.cs

@@ -43,7 +43,7 @@ public async Task Should_Create_Empty_Release()
             _vcsService.CreateEmptyReleaseAsync(options.RepositoryOwner, options.RepositoryName, options.Name, options.TargetCommitish, options.Prerelease)
                 .Returns(_release);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).CreateEmptyReleaseAsync(options.RepositoryOwner, options.RepositoryName, releaseName, options.TargetCommitish, options.Prerelease).ConfigureAwait(false);
@@ -72,7 +72,7 @@ public async Task Should_Create_Release_From_Milestone(string name, int logVerbo
             _vcsService.CreateReleaseFromMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone, releaseName, options.TargetCommitish, options.AssetPaths, options.Prerelease, options.Template)
                 .Returns(_release);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).CreateReleaseFromMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone, releaseName, options.TargetCommitish, options.AssetPaths, options.Prerelease, options.Template).ConfigureAwait(false);
@@ -98,7 +98,7 @@ public async Task Should_Create_Release_From_InputFile()
             _vcsService.CreateReleaseFromInputFileAsync(options.RepositoryOwner, options.RepositoryName, options.Name, options.InputFilePath, options.TargetCommitish, options.AssetPaths, options.Prerelease)
                 .Returns(_release);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).CreateReleaseFromInputFileAsync(options.RepositoryOwner, options.RepositoryName, options.Name, options.InputFilePath, options.TargetCommitish, options.AssetPaths, options.Prerelease).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/DiscardCommandTests.cs

@@ -36,7 +36,7 @@ public async Task Should_Execute_Command()
             _vcsService.DiscardReleaseAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone)
                 .Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).DiscardReleaseAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/ExportCommandTests.cs

@@ -42,7 +42,7 @@ public async Task Should_Execute_Command()
             _vcsService.ExportReleasesAsync(options.RepositoryOwner, options.RepositoryName, options.TagName, options.SkipPrereleases)
                 .Returns(releaseText);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             var exportFileExists = File.Exists(_fileOutputPath);

src/GitReleaseManager.Core.Tests/Commands/InitCommandTests.cs

@@ -40,7 +40,7 @@ public async Task Should_Execute_Command()
         {
             var options = new InitSubOptions { TargetDirectory = _targetDirectory };
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             var configFilePath = Path.Combine(_targetDirectory, "GitReleaseManager.yml");
@@ -70,7 +70,7 @@ public async Task Should_Not_Execute_Command_For_Legacy_FileName()
             File.WriteAllText(configFilePath, "s");
             var expectedHash = GetHash(configFilePath);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0); // Should this perhaps return 1
 
             var actualHash = GetHash(configFilePath);

src/GitReleaseManager.Core.Tests/Commands/LabelCommandTests.cs

@@ -35,7 +35,7 @@ public async Task Should_Execute_Command()
             _vcsService.CreateLabelsAsync(options.RepositoryOwner, options.RepositoryName)
                 .Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).CreateLabelsAsync(options.RepositoryOwner, options.RepositoryName).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/OpenCommandTests.cs

@@ -36,7 +36,7 @@ public async Task Should_Execute_Command()
             _vcsService.OpenMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone)
                 .Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).OpenMilestoneAsync(options.RepositoryOwner, options.RepositoryName, options.Milestone).ConfigureAwait(false);

src/GitReleaseManager.Core.Tests/Commands/PublishCommandTests.cs

@@ -36,7 +36,7 @@ public async Task Should_Execute_Command()
             _vcsService.PublishReleaseAsync(options.RepositoryOwner, options.RepositoryName, options.TagName)
                 .Returns(Task.CompletedTask);
 
-            var result = await _command.Execute(options).ConfigureAwait(false);
+            var result = await _command.ExecuteAsync(options).ConfigureAwait(false);
             result.ShouldBe(0);
 
             await _vcsService.Received(1).PublishReleaseAsync(options.RepositoryOwner, options.RepositoryName, options.TagName).ConfigureAwait(false);