(maint) Fix stylecop and compiler warnings

gep13 · gep13 · commit 5d8146079ab4 · 2023-08-21T09:19:32.000+01:00
While trying to get the builds to work on AppVeyor and GitHub, noticed
that there were a couple of build warnings (both from StyleCop and
MSBuild) that were quick wins, so took the opportunity to fix them up.
diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj
@@ -19,8 +19,6 @@
         </PackageReference>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
         <PackageReference Include="ApprovalTests" Version="5.7.1" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
-        <PackageReference Include="ApprovalTests" Version="5.7.1" />
         <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>
diff --git a/src/GitReleaseManager.Core/Configuration/ConfigSerializer.cs b/src/GitReleaseManager.Core/Configuration/ConfigSerializer.cs
@@ -94,6 +94,7 @@ private static void SetConfigurationSamples(object config, Type configType, Text
                         {
                             property.SetValue(config, null);
                         }
+
                         continue;
                     }
                     else if (yamlMemberAttribute.DefaultValuesHandling == DefaultValuesHandling.OmitNull)
diff --git a/src/GitReleaseManager.Core/Exceptions/InvalidIssuesException.cs b/src/GitReleaseManager.Core/Exceptions/InvalidIssuesException.cs
@@ -33,6 +33,8 @@ public InvalidIssuesException(List<string> errors, string message, Exception inn
         protected InvalidIssuesException(
             System.Runtime.Serialization.SerializationInfo info,
             System.Runtime.Serialization.StreamingContext context)
-            : base(info, context) { }
+            : base(info, context)
+        {
+        }
     }
 }
diff --git a/src/GitReleaseManager.Core/Extensions/StringExtensions.cs b/src/GitReleaseManager.Core/Extensions/StringExtensions.cs
@@ -12,7 +12,7 @@ public static string ReplaceMilestoneTitle(this string source, string milestoneK
         {
             var dict = new Dictionary<string, object>
             {
-                { milestoneKey.Trim('{','}'), milestoneTitle },
+                { milestoneKey.Trim('{','}'), milestoneTitle }
             };
 
             return source.ReplaceTemplate(dict);
diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj
@@ -19,8 +19,6 @@
         </PackageReference>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
         <PackageReference Include="ApprovalTests" Version="5.7.1" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
-        <PackageReference Include="ApprovalTests" Version="5.7.1" />
         <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1">
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ private static void SetConfigurationSamples(object config, Type configType, Text`
`94`	`94`	`{`
`95`	`95`	`property.SetValue(config, null);`
`96`	`96`	`}`
	`97`	`+`
`97`	`98`	`continue;`
`98`	`99`	`}`
`99`	`100`	`else if (yamlMemberAttribute.DefaultValuesHandling == DefaultValuesHandling.OmitNull)`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,8 @@ public InvalidIssuesException(List<string> errors, string message, Exception inn`
`33`	`33`	`protected InvalidIssuesException(`
`34`	`34`	`System.Runtime.Serialization.SerializationInfo info,`
`35`	`35`	`System.Runtime.Serialization.StreamingContext context)`
`36`		`- : base(info, context) { }`
	`36`	`+ : base(info, context)`
	`37`	`+ {`
	`38`	`+ }`
`37`	`39`	`}`
`38`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public static string ReplaceMilestoneTitle(this string source, string milestoneK`
`12`	`12`	`{`
`13`	`13`	`var dict = new Dictionary<string, object>`
`14`	`14`	`{`
`15`		`- { milestoneKey.Trim('{','}'), milestoneTitle },`
	`15`	`+ { milestoneKey.Trim('{','}'), milestoneTitle }`
`16`	`16`	`};`
`17`	`17`
`18`	`18`	`return source.ReplaceTemplate(dict);`