Merge pull request #484 from jibedoubleve/issue_454

Issue 454: Assets on a draft release can be null

Author: gep13

src/GitReleaseManager.Core.Tests/VcsServiceTests.cs

@@ -321,6 +321,45 @@ await _vcsProvider.Received(1).CreateReleaseAsync(OWNER, REPOSITORY, Arg.Is<Rele
             _logger.Received(1).Debug(Arg.Any<string>(), Arg.Any<Release>());
         }
 
+        [Test]
+        public async Task Should_Create_Release_From_Milestone_With_Assets()
+        {
+            var release = new Release { Assets = new List<ReleaseAsset>() };
+
+            var assetsCount = _assets.Count;
+
+            _releaseNotesBuilder.BuildReleaseNotes(OWNER, REPOSITORY, MILESTONE_TITLE, ReleaseTemplates.DEFAULT_NAME)
+                .Returns(Task.FromResult(RELEASE_NOTES));
+
+            _vcsProvider.GetReleaseAsync(OWNER, REPOSITORY, MILESTONE_TITLE)
+                .Returns(Task.FromResult<Release>(null));
+
+            _vcsProvider.CreateReleaseAsync(OWNER, REPOSITORY, Arg.Any<Release>())
+                .Returns(Task.FromResult(release));
+
+            var result = await _vcsService.CreateReleaseFromMilestoneAsync(
+                    OWNER,
+                    REPOSITORY,
+                    MILESTONE_TITLE,
+                    MILESTONE_TITLE,
+                    null,
+                    _assets,
+                    false,
+                    null
+                ).ConfigureAwait(false);
+            result.ShouldBeSameAs(release);
+
+            await _releaseNotesBuilder.Received(1).BuildReleaseNotes(OWNER, REPOSITORY, MILESTONE_TITLE, ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false);
+            await _vcsProvider.Received(1).GetReleaseAsync(OWNER, REPOSITORY, MILESTONE_TITLE).ConfigureAwait(false);
+            await _vcsProvider.Received(1).CreateReleaseAsync(OWNER, REPOSITORY, Arg.Is<Release>(o =>
+                o.Body == RELEASE_NOTES &&
+                o.Name == MILESTONE_TITLE &&
+                o.TagName == MILESTONE_TITLE)).ConfigureAwait(false);
+
+            _logger.Received(1).Verbose(Arg.Any<string>(), MILESTONE_TITLE, OWNER, REPOSITORY);
+            _logger.Received(1).Debug(Arg.Any<string>(), Arg.Any<Release>());
+        }
+
         [Test]
         public async Task Should_Create_Release_From_Milestone_Using_Template_File()
         {

src/GitReleaseManager.Core/VcsService.cs

@@ -101,7 +101,7 @@ private async Task<Release> CreateReleaseAsync(string owner, string repository,
                 await _vcsProvider.UpdateReleaseAsync(owner, repository, release).ConfigureAwait(false);
             }
 
-            await AddAssetsAsync(owner, repository, tagName, assets).ConfigureAwait(false);
+            await AddAssetsAsync(owner, repository, tagName, assets, release).ConfigureAwait(false);
 
             return release;
         }
@@ -127,13 +127,15 @@ public async Task DiscardReleaseAsync(string owner, string repository, string ta
             }
         }
 
-        public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets)
+        public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets) => await AddAssetsAsync(owner, repository, tagName, assets, null);
+
+        private async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets, Release currentRelease)
         {
             if (assets?.Any() == true)
             {
                 try
                 {
-                    var release = await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);
+                    var release = currentRelease ?? await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);
 
                     foreach (var asset in assets)
                     {