Skip to content

Commit 834bfc4

Browse files
committed
(maint) Removed unneeded pragma definitons
1 parent ed01d1e commit 834bfc4

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

Source/GitReleaseManager.IntegrationTests/ClientBuilder.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ public static GitHubClient Build()
1717
{
1818
var credentialStore = new InMemoryCredentialStore(Helper.Credentials);
1919

20-
#pragma warning disable DF0024 // Marks undisposed objects assinged to a field, originated in an object creation.
2120
_httpClient = new HttpClientAdapter(HttpMessageHandlerFactory.CreateDefault);
22-
#pragma warning restore DF0024 // Marks undisposed objects assinged to a field, originated in an object creation.
2321

2422
var connection = new Connection(
2523
new ProductHeaderValue("GitReleaseManager"),

Source/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ public class ReleaseNotesBuilderIntegrationTests
3030
public void Configure()
3131
{
3232
_mapper = AutoMapperConfiguration.Configure();
33-
#pragma warning disable DF0037 // Marks undisposed objects assinged to a property, originated from a method invocation.
3433
Log.Logger = new LoggerConfiguration().WriteTo.Console().CreateLogger();
35-
#pragma warning restore DF0037 // Marks undisposed objects assinged to a property, originated from a method invocation.
3634

3735
_username = Environment.GetEnvironmentVariable("GITTOOLS_GITHUB_USERNAME");
3836
_password = Environment.GetEnvironmentVariable("GITTOOLS_GITHUB_PASSWORD");

Source/GitReleaseManager.Tests/FakeGitHubClient.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ public FakeGitHubClient()
2323
Release = new Release();
2424
}
2525

26-
#pragma warning disable CA1044 // Properties should not be write only
2726
public List<Milestone> Milestones { get; private set; }
2827

2928
public List<Issue> Issues { get; private set; }
@@ -32,8 +31,7 @@ public FakeGitHubClient()
3231

3332
public Release Release { get; private set; }
3433

35-
public int NumberOfCommits { private get; set; }
36-
#pragma warning restore CA1044 // Properties should not be write only
34+
public int NumberOfCommits { get; set; }
3735

3836
public Task<int> GetNumberOfCommitsBetween(Milestone previousMilestone, Milestone currentMilestone, string user, string repository)
3937
{

0 commit comments

Comments
 (0)