Skip to content

Commit bff555d

Browse files
Jerichogep13
authored andcommitted
(#580) Mark the integration test as "inconclusive"
Updated the Release Notes Builder Integration Tests as inconclusive, when the GitHub token is not provided. This ensures consistent behavior with other integration tests.
1 parent 8c41f54 commit bff555d

File tree

1 file changed

+21
-30
lines changed

1 file changed

+21
-30
lines changed

src/GitReleaseManager.IntegrationTests/ReleaseNotesBuilderIntegrationTests.cs

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ public void Configure()
3636
Log.Logger = _logger;
3737

3838
_token = Environment.GetEnvironmentVariable("GITTOOLS_GITHUB_TOKEN");
39+
if (string.IsNullOrWhiteSpace(_token))
40+
{
41+
Assert.Inconclusive("Unable to locate credentials for accessing GitHub API");
42+
}
43+
3944
_gitHubClient = new GitHubClient(new ProductHeaderValue("GitReleaseManager")) { Credentials = new Credentials(_token) };
4045
}
4146

@@ -50,44 +55,30 @@ public void TearDown()
5055
[Explicit]
5156
public async Task SingleMilestone()
5257
{
53-
if (string.IsNullOrWhiteSpace(_token))
54-
{
55-
Assert.Inconclusive("Unable to locate credentials for accessing GitHub API");
56-
}
57-
else
58-
{
59-
var fileSystem = new FileSystem(new CreateSubOptions());
60-
var currentDirectory = Environment.CurrentDirectory;
61-
var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem);
58+
var fileSystem = new FileSystem(new CreateSubOptions());
59+
var currentDirectory = Environment.CurrentDirectory;
60+
var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem);
6261

63-
var vcsProvider = new GitHubProvider(_gitHubClient, _mapper);
64-
var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create));
65-
var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.12.4", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false);
66-
Debug.WriteLine(result);
67-
ClipBoardHelper.SetClipboard(result);
68-
}
62+
var vcsProvider = new GitHubProvider(_gitHubClient, _mapper);
63+
var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create));
64+
var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.12.4", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false);
65+
Debug.WriteLine(result);
66+
ClipBoardHelper.SetClipboard(result);
6967
}
7068

7169
[Test]
7270
[Explicit]
7371
public async Task SingleMilestone3()
7472
{
75-
if (string.IsNullOrWhiteSpace(_token))
76-
{
77-
Assert.Inconclusive("Unable to locate credentials for accessing GitHub API");
78-
}
79-
else
80-
{
81-
var fileSystem = new FileSystem(new CreateSubOptions());
82-
var currentDirectory = Environment.CurrentDirectory;
83-
var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem);
73+
var fileSystem = new FileSystem(new CreateSubOptions());
74+
var currentDirectory = Environment.CurrentDirectory;
75+
var configuration = ConfigurationProvider.Provide(currentDirectory, fileSystem);
8476

85-
var vcsProvider = new GitHubProvider(_gitHubClient, _mapper);
86-
var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create));
87-
var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.13.0", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false);
88-
Debug.WriteLine(result);
89-
ClipBoardHelper.SetClipboard(result);
90-
}
77+
var vcsProvider = new GitHubProvider(_gitHubClient, _mapper);
78+
var releaseNotesBuilder = new ReleaseNotesBuilder(vcsProvider, _logger, fileSystem, configuration, new TemplateFactory(fileSystem, configuration, TemplateKind.Create));
79+
var result = await releaseNotesBuilder.BuildReleaseNotesAsync("Chocolatey", "ChocolateyGUI", "0.13.0", ReleaseTemplates.DEFAULT_NAME).ConfigureAwait(false);
80+
Debug.WriteLine(result);
81+
ClipBoardHelper.SetClipboard(result);
9182
}
9283

9384
[Test]

0 commit comments

Comments
 (0)