(maint) Changed exceptions types to be more specific

Author: AdmiringWorm

Source/GitReleaseManager/Exceptions/InvalidStateException.cs

@@ -0,0 +1,35 @@
+// -----------------------------------------------------------------------
+// <copyright file="InvalidStateException.cs" company="GitTools Contributors">
+// Copyright (c) 2015 - Present - GitTools Contributors
+// </copyright>
+// -----------------------------------------------------------------------
+
+namespace GitReleaseManager.Core.Exceptions
+{
+    using System;
+
+    [Serializable]
+    public class InvalidStateException : Exception
+    {
+        public InvalidStateException()
+        {
+        }
+
+        public InvalidStateException(string message)
+            : base(message)
+        {
+        }
+
+        public InvalidStateException(string message, Exception inner)
+            : base(message, inner)
+        {
+        }
+
+        protected InvalidStateException(
+        System.Runtime.Serialization.SerializationInfo info,
+        System.Runtime.Serialization.StreamingContext context)
+            : base(info, context)
+        {
+        }
+    }
+}

Source/GitReleaseManager/Exceptions/MissingReleaseException.cs

@@ -0,0 +1,35 @@
+// -----------------------------------------------------------------------
+// <copyright file="MissingReleaseException.cs" company="GitTools Contributors">
+// Copyright (c) 2015 - Present - GitTools Contributors
+// </copyright>
+// -----------------------------------------------------------------------
+
+namespace GitReleaseManager.Core.Exceptions
+{
+    using System;
+
+    [Serializable]
+    public class MissingReleaseException : Exception
+    {
+        public MissingReleaseException()
+        {
+        }
+
+        public MissingReleaseException(string message)
+            : base(message)
+        {
+        }
+
+        public MissingReleaseException(string message, Exception inner)
+            : base(message, inner)
+        {
+        }
+
+        protected MissingReleaseException(
+        System.Runtime.Serialization.SerializationInfo info,
+        System.Runtime.Serialization.StreamingContext context)
+            : base(info, context)
+        {
+        }
+    }
+}

Source/GitReleaseManager/GitHubProvider.cs

@@ -18,6 +18,7 @@ namespace GitReleaseManager.Core
     using System.Threading.Tasks;
     using AutoMapper;
     using GitReleaseManager.Core.Configuration;
+    using GitReleaseManager.Core.Exceptions;
     using GitReleaseManager.Core.Extensions;
     using Octokit;
     using Serilog;
@@ -159,7 +160,7 @@ public async Task<Release> CreateReleaseFromMilestone(string owner, string repos
 
                 if (!release.Draft)
                 {
-                    throw new Exception("Release is not in draft state, so not updating.");
+                    throw new InvalidOperationException("Release is not in draft state, so not updating.");
                 }
 
                 var releaseUpdate = release.ToUpdate();
@@ -202,12 +203,12 @@ public async Task DiscardRelease(string owner, string repository, string name)
 
             if (release is null)
             {
-                throw new Exception(string.Format("Unable to find a release with name {0}", name));
+                throw new MissingReleaseException(string.Format("Unable to find a release with name {0}", name));
             }
 
             if (!release.Draft)
             {
-                throw new Exception("Release is not in draft state, so not discarding.");
+                throw new InvalidStateException("Release is not in draft state, so not discarding.");
             }
 
             await _gitHubClient.Repository.Release.Delete(owner, repository, release.Id).ConfigureAwait(false);
@@ -230,7 +231,7 @@ public async Task AddAssets(string owner, string repository, string tagName, ILi
                     if (!File.Exists(asset))
                     {
                         var logMessage = string.Format("Requested asset to be uploaded doesn't exist: {0}", asset);
-                        throw new Exception(logMessage);
+                        throw new FileNotFoundException(logMessage);
                     }
 
                     var assetFileName = Path.GetFileName(asset);

Source/GitReleaseManager/ReleaseNotesBuilder.cs

@@ -52,7 +52,7 @@ public async Task<string> BuildReleaseNotes()
             if (issues.Count == 0)
             {
                 var logMessage = string.Format("No closed issues have been found for milestone {0}, or all assigned issues are meant to be excluded from release notes, aborting creation of release.", _milestoneTitle);
-                throw new Exception(logMessage);
+                throw new InvalidOperationException(logMessage);
             }
 
             if (issues.Count > 0)