(GH-5) Boom! FxCop re-enabled on all projects

- Turns out, naming the output GitHubReleaseNotes.dll and
GitHubReleaseNotes.exe, causes bad things to happen to FxCop.
- Renamed output artifacts, and fixed remaining FxCop erros

Author: Gary Ewan Park

Source/CustomDictionary.xml

@@ -4,6 +4,7 @@
       <Word />
     </Unrecognized>
     <Recognized>
+      <Word>Cli</Word>
       <Word>commitish</Word>
       <Word>Git</Word>
       <Word>Octokit</Word>

Source/GitHubReleaseManager.Cli/GitHubReleaseManager.Cli.csproj

@@ -8,7 +8,7 @@
     <OutputType>Exe</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>GitHubReleaseManager.Cli</RootNamespace>
-    <AssemblyName>GitHubReleaseManager</AssemblyName>
+    <AssemblyName>GitHubReleaseManager.Cli</AssemblyName>
     <TargetFrameworkVersion>v4.5.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <NuGetPackageImportStamp>7ec2b379</NuGetPackageImportStamp>
@@ -53,7 +53,7 @@
     <DefineConstants>TRACE;CODE_ANALYSIS;</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <RunCodeAnalysis>false</RunCodeAnalysis>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
     <CodeAnalysisRuleSet>..\GitHubReleaseManager.ruleset</CodeAnalysisRuleSet>
     <CodeAnalysisTreatWarningsAsErrors>True</CodeAnalysisTreatWarningsAsErrors>
   </PropertyGroup>
@@ -87,12 +87,6 @@
       <SubType>Designer</SubType>
     </None>
   </ItemGroup>
-  <ItemGroup>
-    <ProjectReference Include="..\GitHubReleaseManager\GitHubReleaseManager.csproj">
-      <Project>{b02a026e-ca3a-48f4-bba9-eb337b0a2035}</Project>
-      <Name>GitHubReleaseManager</Name>
-    </ProjectReference>
-  </ItemGroup>
   <ItemGroup>
     <CodeAnalysisDictionary Include="..\CustomDictionary.xml">
       <Link>CustomDictionary.xml</Link>
@@ -118,6 +112,12 @@
   <ItemGroup>
     <Content Include="FodyWeavers.xml" />
   </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\GitHubReleaseManager\GitHubReleaseManager.csproj">
+      <Project>{b02a026e-ca3a-48f4-bba9-eb337b0a2035}</Project>
+      <Name>GitHubReleaseManager</Name>
+    </ProjectReference>
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
     <PropertyGroup>

Source/GitHubReleaseManager.Cli/Program.cs

@@ -14,17 +14,18 @@ namespace GitHubReleaseManager.Cli
     using Octokit;
     using FileMode = System.IO.FileMode;
 
-    public class Program
+    public static class Program
     {
+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Reliability", "CA2000:Dispose objects before losing scope", Justification = "Not required")]
         private static int Main(string[] args)
         {
             var options = new Options();
 
             var result = 1;
 
             if (!Parser.Default.ParseArgumentsStrict(
-                args, 
-                options, 
+                args,
+                options,
                 (verb, subOptions) =>
                     {
                         if (verb == "create")

Source/GitHubReleaseManager.Tests/GitHubReleaseManager.Tests.csproj

@@ -73,7 +73,7 @@
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\GitHubReleaseManager\GitHubReleaseManager.csproj">
-      <Project>{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}</Project>
+      <Project>{b02a026e-ca3a-48f4-bba9-eb337b0a2035}</Project>
       <Name>GitHubReleaseManager</Name>
     </ProjectReference>
   </ItemGroup>

Source/GitHubReleaseManager.sln

@@ -22,22 +22,18 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "AppVeyor", "AppVeyor", "{EF
 		..\appveyor.yml = ..\appveyor.yml
 	EndProjectSection
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GitHubReleaseManager", "GitHubReleaseManager\GitHubReleaseManager.csproj", "{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GitHubReleaseManager.Tests", "GitHubReleaseManager.Tests\GitHubReleaseManager.Tests.csproj", "{FAD045A3-CF63-48CA-BA49-8F4D79E3EF4F}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GitHubReleaseManager.Cli", "GitHubReleaseManager.Cli\GitHubReleaseManager.Cli.csproj", "{F1163F09-3D4E-4F95-AF46-24C15AB297FB}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GitHubReleaseManager", "GitHubReleaseManager\GitHubReleaseManager.csproj", "{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
 		Release|Any CPU = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
-		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Release|Any CPU.Build.0 = Release|Any CPU
 		{FAD045A3-CF63-48CA-BA49-8F4D79E3EF4F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{FAD045A3-CF63-48CA-BA49-8F4D79E3EF4F}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{FAD045A3-CF63-48CA-BA49-8F4D79E3EF4F}.Release|Any CPU.ActiveCfg = Release|Any CPU
@@ -46,6 +42,10 @@ Global
 		{F1163F09-3D4E-4F95-AF46-24C15AB297FB}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{F1163F09-3D4E-4F95-AF46-24C15AB297FB}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{F1163F09-3D4E-4F95-AF46-24C15AB297FB}.Release|Any CPU.Build.0 = Release|Any CPU
+		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{B02A026E-CA3A-48F4-BBA9-EB337B0A2035}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE