(#454) Fix NullReferenceException on release not found

jibedoubleve · gep13 · commit cea2a4372f60 · 2023-08-21T11:05:24.000+01:00
diff --git a/src/GitReleaseManager.Core/VcsService.cs b/src/GitReleaseManager.Core/VcsService.cs
@@ -101,7 +101,7 @@ private async Task<Release> CreateReleaseAsync(string owner, string repository,
                 await _vcsProvider.UpdateReleaseAsync(owner, repository, release).ConfigureAwait(false);
             }
 
-            await AddAssetsAsync(owner, repository, tagName, assets).ConfigureAwait(false);
+            await AddAssetsAsync(owner, repository, tagName, assets, release).ConfigureAwait(false);
 
             return release;
         }
@@ -127,13 +127,15 @@ public async Task DiscardReleaseAsync(string owner, string repository, string ta
             }
         }
 
-        public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets)
+        public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets) => await AddAssetsAsync(owner, repository, tagName, assets, null);
+
+        private async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets, Release currentRelease)
         {
             if (assets?.Any() == true)
             {
                 try
                 {
-                    var release = await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);
+                    var release = currentRelease ?? await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);
 
                     foreach (var asset in assets)
                     {

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ private async Task<Release> CreateReleaseAsync(string owner, string repository,`
`101`	`101`	`await _vcsProvider.UpdateReleaseAsync(owner, repository, release).ConfigureAwait(false);`
`102`	`102`	`}`
`103`	`103`
`104`		`- await AddAssetsAsync(owner, repository, tagName, assets).ConfigureAwait(false);`
	`104`	`+ await AddAssetsAsync(owner, repository, tagName, assets, release).ConfigureAwait(false);`
`105`	`105`
`106`	`106`	`return release;`
`107`	`107`	`}`
`@@ -127,13 +127,15 @@ public async Task DiscardReleaseAsync(string owner, string repository, string ta`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`130`		`- public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets)`
	`130`	`+ public async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets) => await AddAssetsAsync(owner, repository, tagName, assets, null);`
	`131`	`+`
	`132`	`+ private async Task AddAssetsAsync(string owner, string repository, string tagName, IList<string> assets, Release currentRelease)`
`131`	`133`	`{`
`132`	`134`	`if (assets?.Any() == true)`
`133`	`135`	`{`
`134`	`136`	`try`
`135`	`137`	`{`
`136`		`- var release = await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);`
	`138`	`+ var release = currentRelease ?? await _vcsProvider.GetReleaseAsync(owner, repository, tagName).ConfigureAwait(false);`
`137`	`139`
`138`	`140`	`foreach (var asset in assets)`
`139`	`141`	`{`