Skip to content

Commit d815190

Browse files
committed
(#113) Update unit tests for new functionality
We are now throwing a specific exception, rather than an InvalidOperationException. Also, added new tests to assert the correct number of errors returned in the new exception.
1 parent 3c4f8d7 commit d815190

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

src/GitReleaseManager.Tests/ReleaseNotesBuilderTests.cs

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.Threading.Tasks;
55
using ApprovalTests;
66
using GitReleaseManager.Core.Configuration;
7+
using GitReleaseManager.Core.Exceptions;
78
using GitReleaseManager.Core.Helpers;
89
using GitReleaseManager.Core.Model;
910
using GitReleaseManager.Core.Provider;
@@ -150,14 +151,30 @@ public void CorrectlyUseFooterWithMilestoneWhenEnabled()
150151
public void NoCommitsWrongIssueLabel()
151152
{
152153
var exception = Assert.Throws<AggregateException>(() => AcceptTest(0, CreateIssue(1, "Test")));
153-
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidOperationException>());
154+
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidIssuesException>());
154155
}
155156

156157
[Test]
157158
public void SomeCommitsWrongIssueLabel()
158159
{
159160
var exception = Assert.Throws<AggregateException>(() => AcceptTest(5, CreateIssue(1, "Test")));
160-
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidOperationException>());
161+
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidIssuesException>());
162+
}
163+
164+
[Test]
165+
public void NoCommitsMultipleWrongIssueLabel()
166+
{
167+
var exception = Assert.Throws<AggregateException>(() => AcceptTest(0, CreateIssue(1, "Test"), CreateIssue(2, "Test")));
168+
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidIssuesException>());
169+
Assert.That((exception.InnerException as InvalidIssuesException).Errors.Count, Is.EqualTo(2));
170+
}
171+
172+
[Test]
173+
public void SomeCommitsMultipleWrongIssueLabel()
174+
{
175+
var exception = Assert.Throws<AggregateException>(() => AcceptTest(5, CreateIssue(1, "Test"), CreateIssue(2, "Test"), CreateIssue(3, "Bob")));
176+
Assert.That(exception.InnerException, Is.Not.Null.And.TypeOf<InvalidIssuesException>());
177+
Assert.That((exception.InnerException as InvalidIssuesException).Errors.Count, Is.EqualTo(3));
161178
}
162179

163180
[Test]

0 commit comments

Comments
 (0)