@@ -303,7 +303,7 @@ public async Task CloseMilestone(string owner, string repository, string milesto
303
303
304
304
if ( _configuration . Close . IssueComments )
305
305
{
306
- await AddIssueCommentsAsync ( owner , repository , milestoneTitle ) . ConfigureAwait ( false ) ;
306
+ await AddIssueCommentsAsync ( owner , repository , milestone ) . ConfigureAwait ( false ) ;
307
307
}
308
308
}
309
309
@@ -411,11 +411,11 @@ private static string ComputeSha256Hash(string asset)
411
411
}
412
412
}
413
413
414
- private async Task AddIssueCommentsAsync ( string owner , string repository , string milestone )
414
+ private async Task AddIssueCommentsAsync ( string owner , string repository , Octokit . Milestone milestone )
415
415
{
416
416
const string detectionComment = "<!-- GitReleaseManager release comment -->" ;
417
- var issueComment = detectionComment + "\n " + _configuration . Close . IssueCommentFormat . ReplaceTemplate ( new { owner , repository , Milestone = milestone } ) ;
418
- var issues = await GetIssuesFromMilestoneAsync ( owner , repository , milestone ) . ConfigureAwait ( false ) ;
417
+ var issueComment = detectionComment + "\n " + _configuration . Close . IssueCommentFormat . ReplaceTemplate ( new { owner , repository , Milestone = milestone . Title } ) ;
418
+ var issues = await GetIssuesFromMilestoneAsync ( owner , repository , milestone . Number ) . ConfigureAwait ( false ) ;
419
419
420
420
foreach ( var issue in issues )
421
421
{
@@ -472,12 +472,12 @@ private async Task<Release> CreateReleaseFromInputFileInternal(string owner, str
472
472
return _mapper . Map < Octokit . Release , Release > ( release ) ;
473
473
}
474
474
475
- private Task < IReadOnlyList < Octokit . Issue > > GetIssuesFromMilestoneAsync ( string owner , string repository , string milestone , ItemStateFilter state = ItemStateFilter . Closed )
475
+ private Task < IReadOnlyList < Octokit . Issue > > GetIssuesFromMilestoneAsync ( string owner , string repository , int milestoneNumber , ItemStateFilter state = ItemStateFilter . Closed )
476
476
{
477
- _logger . Verbose ( "Finding issues with milestone: '{Milestone}" , milestone ) ;
477
+ _logger . Verbose ( "Finding issues with milestone: '{Milestone}" , milestoneNumber ) ;
478
478
return _gitHubClient . Issue . GetAllForRepository ( owner , repository , new RepositoryIssueRequest
479
479
{
480
- Milestone = milestone ,
480
+ Milestone = milestoneNumber . ToString ( ) ,
481
481
State = state ,
482
482
} ) ;
483
483
}
0 commit comments