Skip to content

Commit f1f6947

Browse files
committed
Merge pull request #68 from gep13/feature/GH-60
(GH-60) Make label comparison case insensitive
2 parents fc854c7 + 3c40136 commit f1f6947

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Source/GitReleaseManager/DefaultGitHubClient.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,16 @@ public ReadOnlyCollection<Milestone> GetMilestones()
6868
{
6969
var milestonesClient = this.gitHubClient.Issue.Milestone;
7070
var closed = milestonesClient.GetForRepository(
71-
this.user,
72-
this.repository,
71+
this.user,
72+
this.repository,
7373
new MilestoneRequest
7474
{
7575
State = ItemState.Closed
7676
}).Result;
7777

7878
var open = milestonesClient.GetForRepository(
79-
this.user,
80-
this.repository,
79+
this.user,
80+
this.repository,
8181
new MilestoneRequest
8282
{
8383
State = ItemState.Open

Source/GitReleaseManager/ReleaseNotesBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ private static void Append(IEnumerable<Issue> issues, string label, StringBuilde
102102

103103
private void CheckForValidLabels(Issue issue)
104104
{
105-
var count = this.configuration.IssueLabelsInclude.Sum(issueLabel => issue.Labels.Count(l => l.Name == issueLabel));
105+
var count = this.configuration.IssueLabelsInclude.Sum(issueLabel => issue.Labels.Count(l => l.Name.ToUpperInvariant() == issueLabel.ToUpperInvariant()));
106106

107107
if (count != 1)
108108
{
109109
var allIssueLabels = this.configuration.IssueLabelsInclude.Union(this.configuration.IssueLabelsExclude).ToList();
110-
var allIssuesExceptLast = allIssueLabels.Take(allIssueLabels.Count() - 1);
110+
var allIssuesExceptLast = allIssueLabels.Take(allIssueLabels.Count - 1);
111111
var lastLabel = allIssueLabels.Last();
112112

113113
var allIssuesExceptLastString = string.Join(", ", allIssuesExceptLast);

0 commit comments

Comments
 (0)