Remove underscore prefix for fields

Evangelink · arturcic · commit 01f61ed40a1e · 2021-07-23T13:39:29.000+02:00
diff --git a/src/GitTools.Testing/Fixtures/RepositoryFixtureBase.cs b/src/GitTools.Testing/Fixtures/RepositoryFixtureBase.cs
@@ -9,7 +9,7 @@ namespace GitTools.Testing
     /// </summary>
     public abstract class RepositoryFixtureBase : IDisposable
     {
-        private readonly SequenceDiagram _sequenceDiagram;
+        private readonly SequenceDiagram sequenceDiagram;
 
         protected RepositoryFixtureBase(Func<string, IRepository> repoBuilder)
             : this(repoBuilder(PathHelper.GetTempPath()))
@@ -18,7 +18,7 @@ protected RepositoryFixtureBase(Func<string, IRepository> repoBuilder)
 
         protected RepositoryFixtureBase(IRepository repository)
         {
-            this._sequenceDiagram = new SequenceDiagram();
+            this.sequenceDiagram = new SequenceDiagram();
             Repository = repository;
             Repository.Config.Set("user.name", "Test");
             Repository.Config.Set("user.email", "test@email.com");
@@ -33,7 +33,7 @@ public string RepositoryPath
 
         public SequenceDiagram SequenceDiagram
         {
-            get { return this._sequenceDiagram; }
+            get { return this.sequenceDiagram; }
         }
 
         /// <summary>
@@ -53,10 +53,10 @@ public virtual void Dispose()
                     e.Message);
             }
 
-            this._sequenceDiagram.End();
+            this.sequenceDiagram.End();
             Console.WriteLine("**Visualisation of test:**");
             Console.WriteLine(string.Empty);
-            Console.WriteLine(this._sequenceDiagram.GetDiagram());
+            Console.WriteLine(this.sequenceDiagram.GetDiagram());
         }
 
         public void Checkout(string branch) => Commands.Checkout(Repository, branch);
@@ -71,28 +71,28 @@ public void MakeATaggedCommit(string tag)
 
         public void ApplyTag(string tag)
         {
-            this._sequenceDiagram.ApplyTag(tag, Repository.Head.FriendlyName);
+            this.sequenceDiagram.ApplyTag(tag, Repository.Head.FriendlyName);
             Repository.ApplyTag(tag);
         }
 
         public void BranchTo(string branchName, string @as = null)
         {
-            this._sequenceDiagram.BranchTo(branchName, Repository.Head.FriendlyName, @as);
+            this.sequenceDiagram.BranchTo(branchName, Repository.Head.FriendlyName, @as);
             var branch = Repository.CreateBranch(branchName);
             Commands.Checkout(Repository, branch);
         }
 
         public void BranchToFromTag(string branchName, string fromTag, string onBranch, string @as = null)
         {
-            this._sequenceDiagram.BranchToFromTag(branchName, fromTag, onBranch, @as);
+            this.sequenceDiagram.BranchToFromTag(branchName, fromTag, onBranch, @as);
             var branch = Repository.CreateBranch(branchName);
             Commands.Checkout(Repository, branch);
         }
 
         public void MakeACommit()
         {
             var to = Repository.Head.FriendlyName;
-            this._sequenceDiagram.MakeACommit(to);
+            this.sequenceDiagram.MakeACommit(to);
             Repository.MakeACommit();
         }
 
@@ -101,7 +101,7 @@ public void MakeACommit()
         /// </summary>
         public void MergeNoFF(string mergeSource)
         {
-            this._sequenceDiagram.Merge(mergeSource, Repository.Head.FriendlyName);
+            this.sequenceDiagram.Merge(mergeSource, Repository.Head.FriendlyName);
             Repository.MergeNoFF(mergeSource, Generate.SignatureNow());
         }
 
diff --git a/src/GitTools.Testing/Fixtures/SequenceDiagram.cs b/src/GitTools.Testing/Fixtures/SequenceDiagram.cs
@@ -9,49 +9,49 @@ namespace GitTools.Testing
     /// </summary>
     public class SequenceDiagram
     {
-        private readonly Dictionary<string, string> _participants = new();
-        private readonly StringBuilder _diagramBuilder;
+        private readonly Dictionary<string, string> participants = new();
+        private readonly StringBuilder diagramBuilder;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="T:SequenceDiagram"/> class.
         /// </summary>
         public SequenceDiagram()
         {
-            this._diagramBuilder = new StringBuilder();
-            this._diagramBuilder.AppendLine("@startuml");
+            this.diagramBuilder = new StringBuilder();
+            this.diagramBuilder.AppendLine("@startuml");
         }
 
         /// <summary>
         /// Activates a branch/participant in the sequence diagram
         /// </summary>
-        public void Activate(string branch) => this._diagramBuilder.AppendLineFormat("activate {0}", GetParticipant(branch));
+        public void Activate(string branch) => this.diagramBuilder.AppendLineFormat("activate {0}", GetParticipant(branch));
 
         /// <summary>
         /// Destroys a branch/participant in the sequence diagram
         /// </summary>
-        public void Destroy(string branch) => this._diagramBuilder.AppendLineFormat("destroy {0}", GetParticipant(branch));
+        public void Destroy(string branch) => this.diagramBuilder.AppendLineFormat("destroy {0}", GetParticipant(branch));
 
         /// <summary>
         /// Creates a participant in the sequence diagram
         /// </summary>
         public void Participant(string participant, string @as = null)
         {
-            this._participants.Add(participant, @as ?? participant);
+            this.participants.Add(participant, @as ?? participant);
             if (@as == null)
-                this._diagramBuilder.AppendLineFormat("participant {0}", participant);
+                this.diagramBuilder.AppendLineFormat("participant {0}", participant);
             else
-                this._diagramBuilder.AppendLineFormat("participant \"{0}\" as {1}", participant, @as);
+                this.diagramBuilder.AppendLineFormat("participant \"{0}\" as {1}", participant, @as);
         }
 
         /// <summary>
         /// Appends a divider with specified text to the sequence diagram
         /// </summary>
-        public void Divider(string text) => this._diagramBuilder.AppendLineFormat("== {0} ==", text);
+        public void Divider(string text) => this.diagramBuilder.AppendLineFormat("== {0} ==", text);
 
         /// <summary>
         /// Appends a note over one or many participants to the sequence diagram
         /// </summary>
-        public void NoteOver(string noteText, string startParticipant, string endParticipant = null, string prefix = null, string color = null) => this._diagramBuilder.AppendLineFormat(
+        public void NoteOver(string noteText, string startParticipant, string endParticipant = null, string prefix = null, string color = null) => this.diagramBuilder.AppendLineFormat(
                 prefix + @"note over {0}{1}{2}
   {3}
 end note",
@@ -63,20 +63,20 @@ public void NoteOver(string noteText, string startParticipant, string endPartici
         /// <summary>
         /// Appends applying a tag to the specified branch/participant to the sequence diagram
         /// </summary>
-        public void ApplyTag(string tag, string toBranch) => this._diagramBuilder.AppendLineFormat("{0} -> {0}: tag {1}", GetParticipant(toBranch), tag);
+        public void ApplyTag(string tag, string toBranch) => this.diagramBuilder.AppendLineFormat("{0} -> {0}: tag {1}", GetParticipant(toBranch), tag);
 
         /// <summary>
         /// Appends branching from a branch to another branch, @as can override the participant name
         /// </summary>
         public void BranchTo(string branchName, string currentName, string @as)
         {
-            if (!this._participants.ContainsKey(branchName))
+            if (!this.participants.ContainsKey(branchName))
             {
-                this._diagramBuilder.Append("create ");
+                this.diagramBuilder.Append("create ");
                 Participant(branchName, @as);
             }
 
-            this._diagramBuilder.AppendLineFormat(
+            this.diagramBuilder.AppendLineFormat(
                 "{0} -> {1}: branch from {2}",
                 GetParticipant(currentName),
                 GetParticipant(branchName), currentName);
@@ -87,41 +87,41 @@ public void BranchTo(string branchName, string currentName, string @as)
         /// </summary>
         public void BranchToFromTag(string branchName, string fromTag, string onBranch, string @as)
         {
-            if (!this._participants.ContainsKey(branchName))
+            if (!this.participants.ContainsKey(branchName))
             {
-                this._diagramBuilder.Append("create ");
+                this.diagramBuilder.Append("create ");
                 Participant(branchName, @as);
             }
 
-            this._diagramBuilder.AppendLineFormat("{0} -> {1}: branch from tag ({2})", GetParticipant(onBranch), GetParticipant(branchName), fromTag);
+            this.diagramBuilder.AppendLineFormat("{0} -> {1}: branch from tag ({2})", GetParticipant(onBranch), GetParticipant(branchName), fromTag);
         }
 
         /// <summary>
         /// Appends a commit on the target participant/branch to the sequence diagram
         /// </summary>
-        public void MakeACommit(string toParticipant) => this._diagramBuilder.AppendLineFormat("{0} -> {0}: commit", GetParticipant(toParticipant));
+        public void MakeACommit(string toParticipant) => this.diagramBuilder.AppendLineFormat("{0} -> {0}: commit", GetParticipant(toParticipant));
 
         /// <summary>
         /// Append a merge to the sequence diagram
         /// </summary>
-        public void Merge(string @from, string to) => this._diagramBuilder.AppendLineFormat("{0} -> {1}: merge", GetParticipant(@from), GetParticipant(to));
+        public void Merge(string @from, string to) => this.diagramBuilder.AppendLineFormat("{0} -> {1}: merge", GetParticipant(@from), GetParticipant(to));
 
         private string GetParticipant(string branch)
         {
-            if (this._participants.ContainsKey(branch))
-                return this._participants[branch];
+            if (this.participants.ContainsKey(branch))
+                return this.participants[branch];
 
             return branch;
         }
 
         /// <summary>
         /// Ends the sequence diagram
         /// </summary>
-        public void End() => this._diagramBuilder.AppendLine("@enduml");
+        public void End() => this.diagramBuilder.AppendLine("@enduml");
 
         /// <summary>
         /// returns the plantUML representation of the Sequence Diagram
         /// </summary>
-        public string GetDiagram() => this._diagramBuilder.ToString();
+        public string GetDiagram() => this.diagramBuilder.ToString();
     }
 }
diff --git a/src/GitVersion.App/OverrideConfigOptionParser.cs b/src/GitVersion.App/OverrideConfigOptionParser.cs
@@ -10,7 +10,7 @@ internal class OverrideConfigOptionParser
         private static readonly Lazy<ILookup<string, PropertyInfo>> _lazySupportedProperties =
             new(GetSupportedProperties, true);
 
-        private readonly Lazy<Config> _lazyConfig = new();
+        private readonly Lazy<Config> lazyConfig = new();
 
         internal static ILookup<string, PropertyInfo> SupportedProperties => _lazySupportedProperties.Value;
 
@@ -66,13 +66,13 @@ internal void SetValue(string key, string value)
                     unwrapped = pi.PropertyType;
 
                 if (unwrapped == typeof(string))
-                    pi.SetValue(this._lazyConfig.Value, unwrappedText);
+                    pi.SetValue(this.lazyConfig.Value, unwrappedText);
                 else if (unwrapped.IsEnum)
                 {
                     try
                     {
                         var parsedEnum = Enum.Parse(unwrapped, unwrappedText);
-                        pi.SetValue(this._lazyConfig.Value, parsedEnum);
+                        pi.SetValue(this.lazyConfig.Value, parsedEnum);
                     }
                     catch (ArgumentException)
                     {
@@ -89,20 +89,20 @@ internal void SetValue(string key, string value)
                 else if (unwrapped == typeof(int))
                 {
                     if (int.TryParse(unwrappedText, out int parsedInt))
-                        pi.SetValue(this._lazyConfig.Value, parsedInt);
+                        pi.SetValue(this.lazyConfig.Value, parsedInt);
                     else
                         throw new WarningException($"Could not parse /overrideconfig option: {key}={value}. Ensure that 'value' is valid integer number.");
                 }
                 else if (unwrapped == typeof(bool))
                 {
                     if (bool.TryParse(unwrappedText, out bool parsedBool))
-                        pi.SetValue(this._lazyConfig.Value, parsedBool);
+                        pi.SetValue(this.lazyConfig.Value, parsedBool);
                     else
                         throw new WarningException($"Could not parse /overrideconfig option: {key}={value}. Ensure that 'value' is 'true' or 'false'.");
                 }
             }
         }
 
-        internal Config GetConfig() => this._lazyConfig.IsValueCreated ? this._lazyConfig.Value : null;
+        internal Config GetConfig() => this.lazyConfig.IsValueCreated ? this.lazyConfig.Value : null;
     }
 }
diff --git a/src/GitVersion.Core/Configuration/ConfigurationBuilder.cs b/src/GitVersion.Core/Configuration/ConfigurationBuilder.cs
@@ -12,13 +12,13 @@ public class ConfigurationBuilder
     {
         private const int DefaultTagPreReleaseWeight = 60000;
 
-        private readonly List<Config> _overrides = new();
+        private readonly List<Config> overrides = new();
 
         public ConfigurationBuilder Add([NotNull] Config config)
         {
             if (config == null) throw new ArgumentNullException(nameof(config));
 
-            this._overrides.Add(config);
+            this.overrides.Add(config);
             return this;
         }
 
@@ -27,7 +27,7 @@ public Config Build()
         {
             var config = CreateDefaultConfiguration();
 
-            foreach (var overrideConfig in this._overrides)
+            foreach (var overrideConfig in this.overrides)
             {
                 ApplyOverrides(config, overrideConfig);
             }
diff --git a/src/GitVersion.MsBuild.Tests/Mocks/MockEngine.cs b/src/GitVersion.MsBuild.Tests/Mocks/MockEngine.cs
@@ -11,8 +11,8 @@ namespace GitVersion.MsBuild.Tests.Mocks
 {
     internal sealed class MockEngine : IBuildEngine4
     {
-        private readonly ConcurrentDictionary<object, object> _objectCache = new();
-        private StringBuilder _log = new();
+        private readonly ConcurrentDictionary<object, object> objectCache = new();
+        private StringBuilder log = new();
 
         internal MessageImportance MinimumMessageImportance { get; set; } = MessageImportance.Low;
 
@@ -27,21 +27,21 @@ internal sealed class MockEngine : IBuildEngine4
         public void LogErrorEvent(BuildErrorEventArgs eventArgs)
         {
             Console.WriteLine(EventArgsFormatting.FormatEventMessage(eventArgs));
-            this._log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));
+            this.log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));
             ++Errors;
         }
 
         public void LogWarningEvent(BuildWarningEventArgs eventArgs)
         {
             Console.WriteLine(EventArgsFormatting.FormatEventMessage(eventArgs));
-            this._log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));
+            this.log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));
             ++Warnings;
         }
 
         public void LogCustomEvent(CustomBuildEventArgs eventArgs)
         {
             Console.WriteLine(eventArgs.Message);
-            this._log.AppendLine(eventArgs.Message);
+            this.log.AppendLine(eventArgs.Message);
         }
 
         public void LogMessageEvent(BuildMessageEventArgs eventArgs)
@@ -50,7 +50,7 @@ public void LogMessageEvent(BuildMessageEventArgs eventArgs)
             if (eventArgs.Importance <= MinimumMessageImportance)
             {
                 Console.WriteLine(eventArgs.Message);
-                this._log.AppendLine(eventArgs.Message);
+                this.log.AppendLine(eventArgs.Message);
                 ++Messages;
             }
         }
@@ -65,8 +65,8 @@ public void LogMessageEvent(BuildMessageEventArgs eventArgs)
 
         public string Log
         {
-            set => this._log = new StringBuilder(value);
-            get => this._log.ToString();
+            set => this.log = new StringBuilder(value);
+            get => this.log.ToString();
         }
 
         public bool BuildProjectFile(string projectFileName, string[] targetNames, IDictionary globalProperties, IDictionary targetOutputs) => false;
@@ -114,15 +114,15 @@ public void Reacquire()
 
         public object GetRegisteredTaskObject(object key, RegisteredTaskObjectLifetime lifetime)
         {
-            this._objectCache.TryGetValue(key, out var obj);
+            this.objectCache.TryGetValue(key, out var obj);
             return obj;
         }
 
-        public void RegisterTaskObject(object key, object obj, RegisteredTaskObjectLifetime lifetime, bool allowEarlyCollection) => this._objectCache[key] = obj;
+        public void RegisterTaskObject(object key, object obj, RegisteredTaskObjectLifetime lifetime, bool allowEarlyCollection) => this.objectCache[key] = obj;
 
         public object UnregisterTaskObject(object key, RegisteredTaskObjectLifetime lifetime)
         {
-            this._objectCache.TryRemove(key, out var obj);
+            this.objectCache.TryRemove(key, out var obj);
             return obj;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace GitTools.Testing`
`9`	`9`	`/// </summary>`
`10`	`10`	`public abstract class RepositoryFixtureBase : IDisposable`
`11`	`11`	`{`
`12`		`- private readonly SequenceDiagram _sequenceDiagram;`
	`12`	`+ private readonly SequenceDiagram sequenceDiagram;`
`13`	`13`
`14`	`14`	`protected RepositoryFixtureBase(Func<string, IRepository> repoBuilder)`
`15`	`15`	`: this(repoBuilder(PathHelper.GetTempPath()))`
`@@ -18,7 +18,7 @@ protected RepositoryFixtureBase(Func<string, IRepository> repoBuilder)`
`18`	`18`
`19`	`19`	`protected RepositoryFixtureBase(IRepository repository)`
`20`	`20`	`{`
`21`		`- this._sequenceDiagram = new SequenceDiagram();`
	`21`	`+ this.sequenceDiagram = new SequenceDiagram();`
`22`	`22`	`Repository = repository;`
`23`	`23`	`Repository.Config.Set("user.name", "Test");`
`24`	`24`	`Repository.Config.Set("user.email", "[email protected]");`
`@@ -33,7 +33,7 @@ public string RepositoryPath`
`33`	`33`
`34`	`34`	`public SequenceDiagram SequenceDiagram`
`35`	`35`	`{`
`36`		`- get { return this._sequenceDiagram; }`
	`36`	`+ get { return this.sequenceDiagram; }`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`/// <summary>`
`@@ -53,10 +53,10 @@ public virtual void Dispose()`
`53`	`53`	`e.Message);`
`54`	`54`	`}`
`55`	`55`
`56`		`- this._sequenceDiagram.End();`
	`56`	`+ this.sequenceDiagram.End();`
`57`	`57`	`Console.WriteLine("Visualisation of test:");`
`58`	`58`	`Console.WriteLine(string.Empty);`
`59`		`- Console.WriteLine(this._sequenceDiagram.GetDiagram());`
	`59`	`+ Console.WriteLine(this.sequenceDiagram.GetDiagram());`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`public void Checkout(string branch) => Commands.Checkout(Repository, branch);`
`@@ -71,28 +71,28 @@ public void MakeATaggedCommit(string tag)`
`71`	`71`
`72`	`72`	`public void ApplyTag(string tag)`
`73`	`73`	`{`
`74`		`- this._sequenceDiagram.ApplyTag(tag, Repository.Head.FriendlyName);`
	`74`	`+ this.sequenceDiagram.ApplyTag(tag, Repository.Head.FriendlyName);`
`75`	`75`	`Repository.ApplyTag(tag);`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`public void BranchTo(string branchName, string @as = null)`
`79`	`79`	`{`
`80`		`- this._sequenceDiagram.BranchTo(branchName, Repository.Head.FriendlyName, @as);`
	`80`	`+ this.sequenceDiagram.BranchTo(branchName, Repository.Head.FriendlyName, @as);`
`81`	`81`	`var branch = Repository.CreateBranch(branchName);`
`82`	`82`	`Commands.Checkout(Repository, branch);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`public void BranchToFromTag(string branchName, string fromTag, string onBranch, string @as = null)`
`86`	`86`	`{`
`87`		`- this._sequenceDiagram.BranchToFromTag(branchName, fromTag, onBranch, @as);`
	`87`	`+ this.sequenceDiagram.BranchToFromTag(branchName, fromTag, onBranch, @as);`
`88`	`88`	`var branch = Repository.CreateBranch(branchName);`
`89`	`89`	`Commands.Checkout(Repository, branch);`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`public void MakeACommit()`
`93`	`93`	`{`
`94`	`94`	`var to = Repository.Head.FriendlyName;`
`95`		`- this._sequenceDiagram.MakeACommit(to);`
	`95`	`+ this.sequenceDiagram.MakeACommit(to);`
`96`	`96`	`Repository.MakeACommit();`
`97`	`97`	`}`
`98`	`98`
`@@ -101,7 +101,7 @@ public void MakeACommit()`
`101`	`101`	`/// </summary>`
`102`	`102`	`public void MergeNoFF(string mergeSource)`
`103`	`103`	`{`
`104`		`- this._sequenceDiagram.Merge(mergeSource, Repository.Head.FriendlyName);`
	`104`	`+ this.sequenceDiagram.Merge(mergeSource, Repository.Head.FriendlyName);`
`105`	`105`	`Repository.MergeNoFF(mergeSource, Generate.SignatureNow());`
`106`	`106`	`}`
`107`	`107`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ internal class OverrideConfigOptionParser`
`10`	`10`	`private static readonly Lazy<ILookup<string, PropertyInfo>> _lazySupportedProperties =`
`11`	`11`	`new(GetSupportedProperties, true);`
`12`	`12`
`13`		`- private readonly Lazy<Config> _lazyConfig = new();`
	`13`	`+ private readonly Lazy<Config> lazyConfig = new();`
`14`	`14`
`15`	`15`	`internal static ILookup<string, PropertyInfo> SupportedProperties => _lazySupportedProperties.Value;`
`16`	`16`
`@@ -66,13 +66,13 @@ internal void SetValue(string key, string value)`
`66`	`66`	`unwrapped = pi.PropertyType;`
`67`	`67`
`68`	`68`	`if (unwrapped == typeof(string))`
`69`		`- pi.SetValue(this._lazyConfig.Value, unwrappedText);`
	`69`	`+ pi.SetValue(this.lazyConfig.Value, unwrappedText);`
`70`	`70`	`else if (unwrapped.IsEnum)`
`71`	`71`	`{`
`72`	`72`	`try`
`73`	`73`	`{`
`74`	`74`	`var parsedEnum = Enum.Parse(unwrapped, unwrappedText);`
`75`		`- pi.SetValue(this._lazyConfig.Value, parsedEnum);`
	`75`	`+ pi.SetValue(this.lazyConfig.Value, parsedEnum);`
`76`	`76`	`}`
`77`	`77`	`catch (ArgumentException)`
`78`	`78`	`{`
`@@ -89,20 +89,20 @@ internal void SetValue(string key, string value)`
`89`	`89`	`else if (unwrapped == typeof(int))`
`90`	`90`	`{`
`91`	`91`	`if (int.TryParse(unwrappedText, out int parsedInt))`
`92`		`- pi.SetValue(this._lazyConfig.Value, parsedInt);`
	`92`	`+ pi.SetValue(this.lazyConfig.Value, parsedInt);`
`93`	`93`	`else`
`94`	`94`	`throw new WarningException($"Could not parse /overrideconfig option: {key}={value}. Ensure that 'value' is valid integer number.");`
`95`	`95`	`}`
`96`	`96`	`else if (unwrapped == typeof(bool))`
`97`	`97`	`{`
`98`	`98`	`if (bool.TryParse(unwrappedText, out bool parsedBool))`
`99`		`- pi.SetValue(this._lazyConfig.Value, parsedBool);`
	`99`	`+ pi.SetValue(this.lazyConfig.Value, parsedBool);`
`100`	`100`	`else`
`101`	`101`	`throw new WarningException($"Could not parse /overrideconfig option: {key}={value}. Ensure that 'value' is 'true' or 'false'.");`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`
`106`		`- internal Config GetConfig() => this._lazyConfig.IsValueCreated ? this._lazyConfig.Value : null;`
	`106`	`+ internal Config GetConfig() => this.lazyConfig.IsValueCreated ? this.lazyConfig.Value : null;`
`107`	`107`	`}`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,13 @@ public class ConfigurationBuilder`
`12`	`12`	`{`
`13`	`13`	`private const int DefaultTagPreReleaseWeight = 60000;`
`14`	`14`
`15`		`- private readonly List<Config> _overrides = new();`
	`15`	`+ private readonly List<Config> overrides = new();`
`16`	`16`
`17`	`17`	`public ConfigurationBuilder Add([NotNull] Config config)`
`18`	`18`	`{`
`19`	`19`	`if (config == null) throw new ArgumentNullException(nameof(config));`
`20`	`20`
`21`		`- this._overrides.Add(config);`
	`21`	`+ this.overrides.Add(config);`
`22`	`22`	`return this;`
`23`	`23`	`}`
`24`	`24`
`@@ -27,7 +27,7 @@ public Config Build()`
`27`	`27`	`{`
`28`	`28`	`var config = CreateDefaultConfiguration();`
`29`	`29`
`30`		`- foreach (var overrideConfig in this._overrides)`
	`30`	`+ foreach (var overrideConfig in this.overrides)`
`31`	`31`	`{`
`32`	`32`	`ApplyOverrides(config, overrideConfig);`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ namespace GitVersion.MsBuild.Tests.Mocks`
`11`	`11`	`{`
`12`	`12`	`internal sealed class MockEngine : IBuildEngine4`
`13`	`13`	`{`
`14`		`- private readonly ConcurrentDictionary<object, object> _objectCache = new();`
`15`		`- private StringBuilder _log = new();`
	`14`	`+ private readonly ConcurrentDictionary<object, object> objectCache = new();`
	`15`	`+ private StringBuilder log = new();`
`16`	`16`
`17`	`17`	`internal MessageImportance MinimumMessageImportance { get; set; } = MessageImportance.Low;`
`18`	`18`
`@@ -27,21 +27,21 @@ internal sealed class MockEngine : IBuildEngine4`
`27`	`27`	`public void LogErrorEvent(BuildErrorEventArgs eventArgs)`
`28`	`28`	`{`
`29`	`29`	`Console.WriteLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
`30`		`- this._log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
	`30`	`+ this.log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
`31`	`31`	`++Errors;`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`public void LogWarningEvent(BuildWarningEventArgs eventArgs)`
`35`	`35`	`{`
`36`	`36`	`Console.WriteLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
`37`		`- this._log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
	`37`	`+ this.log.AppendLine(EventArgsFormatting.FormatEventMessage(eventArgs));`
`38`	`38`	`++Warnings;`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`public void LogCustomEvent(CustomBuildEventArgs eventArgs)`
`42`	`42`	`{`
`43`	`43`	`Console.WriteLine(eventArgs.Message);`
`44`		`- this._log.AppendLine(eventArgs.Message);`
	`44`	`+ this.log.AppendLine(eventArgs.Message);`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`public void LogMessageEvent(BuildMessageEventArgs eventArgs)`
`@@ -50,7 +50,7 @@ public void LogMessageEvent(BuildMessageEventArgs eventArgs)`
`50`	`50`	`if (eventArgs.Importance <= MinimumMessageImportance)`
`51`	`51`	`{`
`52`	`52`	`Console.WriteLine(eventArgs.Message);`
`53`		`- this._log.AppendLine(eventArgs.Message);`
	`53`	`+ this.log.AppendLine(eventArgs.Message);`
`54`	`54`	`++Messages;`
`55`	`55`	`}`
`56`	`56`	`}`
`@@ -65,8 +65,8 @@ public void LogMessageEvent(BuildMessageEventArgs eventArgs)`
`65`	`65`
`66`	`66`	`public string Log`
`67`	`67`	`{`
`68`		`- set => this._log = new StringBuilder(value);`
`69`		`- get => this._log.ToString();`
	`68`	`+ set => this.log = new StringBuilder(value);`
	`69`	`+ get => this.log.ToString();`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public bool BuildProjectFile(string projectFileName, string[] targetNames, IDictionary globalProperties, IDictionary targetOutputs) => false;`
`@@ -114,15 +114,15 @@ public void Reacquire()`
`114`	`114`
`115`	`115`	`public object GetRegisteredTaskObject(object key, RegisteredTaskObjectLifetime lifetime)`
`116`	`116`	`{`
`117`		`- this._objectCache.TryGetValue(key, out var obj);`
	`117`	`+ this.objectCache.TryGetValue(key, out var obj);`
`118`	`118`	`return obj;`
`119`	`119`	`}`
`120`	`120`
`121`		`- public void RegisterTaskObject(object key, object obj, RegisteredTaskObjectLifetime lifetime, bool allowEarlyCollection) => this._objectCache[key] = obj;`
	`121`	`+ public void RegisterTaskObject(object key, object obj, RegisteredTaskObjectLifetime lifetime, bool allowEarlyCollection) => this.objectCache[key] = obj;`
`122`	`122`
`123`	`123`	`public object UnregisterTaskObject(object key, RegisteredTaskObjectLifetime lifetime)`
`124`	`124`	`{`
`125`		`- this._objectCache.TryRemove(key, out var obj);`
	`125`	`+ this.objectCache.TryRemove(key, out var obj);`
`126`	`126`	`return obj;`
`127`	`127`	`}`
`128`	`128`	`}`