Skip to content

Commit 088835c

Browse files
authored
Merge pull request #943 from pascalberger/FixTfsTaskBuild
Fix tfs task build
2 parents 99e363e + 68411ec commit 088835c

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

src/GitVersionExe/GitVersionExe.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
<Copy SourceFiles="$(SolutionDir)GitVersionTfsTask\task.json" DestinationFolder="$(BuildDir)GitVersionTfsTaskBuild\GitVersionTask" />
189189
<Copy SourceFiles="$(SolutionDir)GitVersionTfsTask\GitVersion.ps1" DestinationFolder="$(BuildDir)GitVersionTfsTaskBuild\GitVersionTask" />
190190
<ReplaceFileText InputFilename="$(BuildDir)GitVersionTfsTaskBuild\manifest.json" OutputFilename="$(BuildDir)GitVersionTfsTaskBuild\manifest.json" MatchExpression="\$version\$" ReplacementText="$(GitVersion_SemVer)" Condition="'$(GitVersion_SemVer)' != ''" />
191-
<Exec Command="powershell -ExecutionPolicy RemoteSigned -NoProfile &quot;$(SolutionDir)GitVersionTfsTask\Update-GitVersionTfsTaskVersion.ps1 $(BuildDir)GitVersionTfsTaskBuild\GitVersionTask\task.json $(GitVersion_Major) $(GitVersion_Minor) $(GitVersion_Patch)&quot;" WorkingDirectory="$(BuildDir)" Condition="'$(GitVersion_SemVer)' != ''" />
191+
<Exec Command="powershell -ExecutionPolicy RemoteSigned -NoProfile &quot;$(SolutionDir)GitVersionTfsTask\Update-GitVersionTfsTaskVersion.ps1 $(BuildDir)GitVersionTfsTaskBuild\GitVersionTask\task.json $(GitVersion_MajorMinorPatch)&quot;" WorkingDirectory="$(BuildDir)" Condition="'$(GitVersion_MajorMinorPatch)' != ''" />
192192
<Exec Command="powershell -ExecutionPolicy RemoteSigned -NoProfile &quot;$(SolutionDir)GitVersionTfsTask\Create-Vsix.ps1 $(BuildDir)GitVersionTfsTaskBuild&quot;" Condition="'$(GitVersion_SemVer)' != ''" />
193193

194194
<!-- Gem -->

src/GitVersionTfsTask/Update-GitVersionTfsTaskVersion.ps1

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,26 @@
11
param (
22
[string] $filePath,
3-
[string] $major,
4-
[string] $minor,
5-
[string] $patch
3+
[string] $version
64
)
75

6+
if ([string]::IsNullOrWhiteSpace($filePath)) {
7+
throw "File path needs to be provided."
8+
}
9+
10+
if ([string]::IsNullOrWhiteSpace($version)) {
11+
throw "Version number needs to be provided."
12+
}
13+
14+
Write-Host "Set version in '$filePath' to $version"
15+
16+
$ver = [Version]$version
17+
818
# Get the task.json as a powershell object
919
$task = Get-Content -Raw -Path $filePath | ConvertFrom-Json
1020

11-
$task.version.Major = $major
12-
$task.version.Minor = $minor
13-
$task.version.Patch = $patch
21+
$task.version.Major = $ver.Major
22+
$task.version.Minor = $ver.Minor
23+
$task.version.Patch = $ver.Build
1424

1525
# get this as a string again
1626

0 commit comments

Comments
 (0)