Skip to content

Commit 0c2287b

Browse files
committed
split GitVersion.MsBuild properties for .net full and core
1 parent e974d86 commit 0c2287b

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.props

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@
44
<PropertyGroup>
55
<GitVersionOutputFile>$(MSBuildProjectDirectory)/gitversion.json</GitVersionOutputFile>
66

7-
<GitVersionFileExe Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)net48/gitversion.exe</GitVersionFileExe>
8-
<GitVersionFileExe Condition="'$(MSBuildRuntimeType)' == 'Core'">dotnet $(MSBuildThisFileDirectory)netstandard2.0/gitversion.dll</GitVersionFileExe>
9-
10-
<GitVersionAssemblyFile Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)net48/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
11-
<GitVersionAssemblyFile Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)netstandard2.0/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
12-
137
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">$(MSBuildProjectDirectory)/../</SolutionDir>
148
<GitVersionPath Condition="'$(GitVersionPath)' == '' And '$(GitVersionUseSolutionDir)' == 'true'">$(SolutionDir)</GitVersionPath>
159
<GitVersionPath Condition="'$(GitVersionPath)' == ''">$(MSBuildProjectDirectory)</GitVersionPath>
@@ -22,6 +16,16 @@
2216
<GitVersion_ToolArgments Condition=" '$(GitVersion_NoNormalizeEnabled)' == 'true' ">$(GitVersion_ToolArgments) -nonormalize</GitVersion_ToolArgments>
2317
</PropertyGroup>
2418

19+
<PropertyGroup Condition="'$(MSBuildRuntimeType)' == 'Full'">
20+
<GitVersionFileExe>$(MSBuildThisFileDirectory)net48/gitversion.exe</GitVersionFileExe>
21+
<GitVersionAssemblyFile>$(MSBuildThisFileDirectory)net48/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
22+
</PropertyGroup>
23+
24+
<PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp3.1'">
25+
<GitVersionFileExe>dotnet $(MSBuildThisFileDirectory)netcoreapp3.1/gitversion.dll</GitVersionFileExe>
26+
<GitVersionAssemblyFile>$(MSBuildThisFileDirectory)netcoreapp3.1/GitVersion.MsBuild.dll</GitVersionAssemblyFile>
27+
</PropertyGroup>
28+
2529
<PropertyGroup>
2630
<DisableGitVersionTask Condition=" '$(DisableGitVersionTask)' == '' ">false</DisableGitVersionTask>
2731

@@ -52,7 +56,7 @@
5256

5357
<GenerateGitVersionWixDefines Condition=" '$(DisableGitVersionTask)' == 'true' ">false</GenerateGitVersionWixDefines>
5458
<GenerateGitVersionWixDefines Condition=" '$(GenerateGitVersionWixDefines)' == '' ">true</GenerateGitVersionWixDefines>
55-
59+
5660
<!-- Property that enables setting of Version -->
5761
<UpdateVersionProperties Condition=" '$(DisableGitVersionTask)' == 'true' ">false</UpdateVersionProperties>
5862
<UpdateVersionProperties Condition=" '$(UpdateVersionProperties)' == '' ">true</UpdateVersionProperties>

src/GitVersion.MsBuild/nuget-files.props

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,16 @@
44
<FullPublishTask>../GitVersionExe/bin/$(Configuration)/net48</FullPublishTask>
55
<CorePublishTask>../GitVersionExe/bin/$(Configuration)/netcoreapp3.1/publish</CorePublishTask>
66
<FullTarget>tools/net48</FullTarget>
7-
<CoreTarget>tools/netstandard2.0</CoreTarget>
7+
<CoreTarget>tools/netcoreapp3.1</CoreTarget>
88
</PropertyGroup>
99
<ItemGroup>
10-
<None Include="msbuild/tools/*.*" Pack="true" PackagePath="tools" />
11-
<None Include="msbuild/build/*.*" Pack="true" PackagePath="build" />
12-
<None Include="msbuild/buildMultiTargeting/*.*" Pack="true" PackagePath="buildMultiTargeting" />
13-
14-
<None Include="$(CorePublishTask)/**/*" Pack="true" PackagePath="$(CoreTarget)" />
15-
<None Include="$(FullPublishTask)/**/*" Pack="true" PackagePath="$(FullTarget)" />
16-
17-
<None Include="bin/$(Configuration)/netstandard2.0/GitVersion.MsBuild.dll" Pack="true" PackagePath="$(FullTarget)" />
18-
<None Include="bin/$(Configuration)/netstandard2.0/GitVersion.MsBuild.dll" Pack="true" PackagePath="$(CoreTarget)" />
10+
<None Include="msbuild/tools/*.*" Pack="true" PackagePath="tools" />
11+
<None Include="msbuild/build/*.*" Pack="true" PackagePath="build" />
12+
<None Include="msbuild/buildMultiTargeting/*.*" Pack="true" PackagePath="buildMultiTargeting" />
1913

14+
<None Include="$(CorePublishTask)/**/*" Pack="true" PackagePath="$(CoreTarget)" />
15+
<None Include="$(FullPublishTask)/**/*" Pack="true" PackagePath="$(FullTarget)" />
16+
<None Include="bin/$(Configuration)/netstandard2.0/GitVersion.MsBuild.*" Pack="true" PackagePath="$(FullTarget)" />
17+
<None Include="bin/$(Configuration)/netstandard2.0/GitVersion.MsBuild.*" Pack="true" PackagePath="$(CoreTarget)" />
2018
</ItemGroup>
2119
</Project>

0 commit comments

Comments
 (0)