Skip to content

Commit 0da2d98

Browse files
committed
Fixed #1046
1 parent c2d4c60 commit 0da2d98

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

src/GitVersionCore.Tests/IntegrationTests/DevelopScenarios.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public void InheritVersionFromReleaseBranch()
178178
fixture.AssertFullSemver("2.1.0-alpha.4");
179179
fixture.BranchTo("feature/MyFeature");
180180
fixture.MakeACommit();
181-
fixture.AssertFullSemver("2.1.0-MyFeature.1+3");
181+
fixture.AssertFullSemver("2.1.0-MyFeature.1+5");
182182
}
183183
}
184184
}

src/GitVersionCore.Tests/IntegrationTests/ReleaseBranchScenarios.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ public void WhenReleaseBranchIsMergedIntoDevelopHighestVersionIsTakenWithIt()
225225
Commands.Checkout(fixture.Repository, "develop");
226226
fixture.Repository.MergeNoFF("release-1.0.0", Generate.SignatureNow());
227227

228-
fixture.AssertFullSemver("2.1.0-alpha.6");
228+
fixture.AssertFullSemver("2.1.0-alpha.11");
229229
}
230230
}
231231

src/GitVersionCore/GitRepoMetadataProvider.cs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,9 @@ public Commit FindMergeBase(Branch branch, Branch otherBranch)
143143
.Any(c => c.Parents.Contains(findMergeBase));
144144
if (mergeBaseWasForwardMerge)
145145
{
146-
var second = commitToFindCommonBase.Parents.First();
147-
var mergeBase = this.Repository.ObjectDatabase.FindMergeBase(commit, second);
148-
if (mergeBase == findMergeBase)
149-
{
150-
break;
151-
}
152-
findMergeBase = mergeBase;
146+
commitToFindCommonBase = commitToFindCommonBase.Parents.First();
147+
findMergeBase = this.Repository.ObjectDatabase.FindMergeBase(commit, commitToFindCommonBase);
148+
153149
Logger.WriteInfo(string.Format("Merge base was due to a forward merge, next merge base is {0}", findMergeBase));
154150
}
155151
} while (mergeBaseWasForwardMerge);

0 commit comments

Comments
 (0)