cleanup

Author: arturcic

src/GitVersion.BuildAgents/Agents/GitHubActions.cs

@@ -25,7 +25,7 @@ public override void WriteIntegration(Action<string?> writer, GitVersionVariable
 
         // https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
         // The outgoing environment variables must be written to a temporary file (identified by the $GITHUB_ENV environment
-        // variable, which changes for every step in a workflow) which is then parsed. That file must also be UTF-8 or it will fail.
+        // variable, which changes for every step in a workflow) which is then parsed. That file must also be UTF-8, or it will fail.
         var gitHubSetEnvFilePath = this.Environment.GetEnvironmentVariable(GitHubSetEnvTempFileEnvironmentVariableName);
 
         if (gitHubSetEnvFilePath != null)

src/GitVersion.BuildAgents/Agents/MyGet.cs

@@ -29,7 +29,7 @@ public override string[] GenerateSetParameterMessage(string name, string? value)
             messages.Add($"##myget[buildNumber '{ServiceMessageEscapeHelper.EscapeValue(value)}']");
         }
 
-        return messages.ToArray();
+        return [.. messages];
     }
 
     public override string? GenerateSetVersionMessage(GitVersionVariables variables) => null;

src/GitVersion.Core/Core/BranchesContainingCommitFinder.cs

@@ -12,7 +12,7 @@ internal class BranchesContainingCommitFinder(IGitRepository repository, ILog lo
     public IEnumerable<IBranch> GetBranchesContainingCommit(ICommit commit, IEnumerable<IBranch>? branches = null, bool onlyTrackedBranches = false)
     {
         commit.NotNull();
-        branches ??= this.repository.Branches.ToList();
+        branches ??= [.. this.repository.Branches];
 
         // TODO Should we cache this?
         // Yielding part is split from the main part of the method to avoid having the exception check performed lazily.

src/GitVersion.MsBuild.Tests/Tasks/TestTaskBase.cs

@@ -48,7 +48,7 @@ protected static MsBuildTaskFixtureResult<T> ExecuteMsBuildTaskInAzurePipeline<T
         task.SolutionDirectory = fixture.LocalRepositoryFixture.RepositoryPath;
         AddOverrides(task);
         var msbuildFixture = new MsBuildTaskFixture(fixture);
-        var environmentVariables = new List<KeyValuePair<string, string?>>(env.ToArray());
+        var environmentVariables = env.ToList();
         if (buildNumber != null)
         {
             environmentVariables.Add(new("BUILD_BUILDNUMBER", buildNumber));
@@ -78,6 +78,7 @@ protected static MsBuildTaskFixtureResult<T> ExecuteMsBuildTaskInGitHubActions<T
         var result = msbuildFixture.Execute(task);
         if (!result.Success)
             Console.WriteLine(result.Log);
+
         return result;
     }