Fix to prevent mainline tag promotion to become a pre-release numeric tag

Author: carlos-vicente

src/GitVersionCore.Tests/IntegrationTests/OtherScenarios.cs

@@ -78,7 +78,7 @@ public void AllowHavingMainInsteadOfMaster()
             Commands.Checkout(fixture.Repository, fixture.Repository.CreateBranch("main"));
             fixture.Repository.Branches.Remove(fixture.Repository.Branches["master"]);
 
-            fixture.AssertFullSemver("0.1.0+0", config);
+            fixture.AssertFullSemver("0.1.0-1+0", config);
         }
 
         [Test]

src/GitVersionCore/VersionCalculation/SemanticVersioning/SemanticVersionPreReleaseTag.cs

@@ -25,10 +25,12 @@ public SemanticVersionPreReleaseTag(SemanticVersionPreReleaseTag preReleaseTag)
         {
             Name = preReleaseTag.Name;
             Number = preReleaseTag.Number;
+            PromotedFromCommits = preReleaseTag.PromotedFromCommits;
         }
 
         public string Name { get; set; }
         public int? Number { get; set; }
+        public bool PromotedFromCommits { get; set; }
 
         public override bool Equals(object obj)
         {
@@ -188,13 +190,17 @@ private string FormatLegacy(string tag, string number = "")
 
         private string GetLegacyName()
         {
+            if (string.IsNullOrEmpty(Name))
+            {
+                return string.Empty;
+            }
             var firstPart = Name.Split('_')[0];
             return firstPart.Replace(".", string.Empty);
         }
 
         public bool HasTag()
         {
-            return !string.IsNullOrEmpty(Name) || Number.HasValue;
+            return !string.IsNullOrEmpty(Name) || (Number.HasValue && !PromotedFromCommits);
         }
     }
 }

src/GitVersionCore/VersionCalculation/VariableProvider.cs

@@ -116,6 +116,7 @@ private static void PromoteNumberOfCommitsToTagNumber(SemanticVersion semanticVe
                 else
                 {
                     semanticVersion.PreReleaseTag.Number = semanticVersion.BuildMetaData.CommitsSinceTag;
+                    semanticVersion.PreReleaseTag.PromotedFromCommits = true;
                 }
                 semanticVersion.BuildMetaData.CommitsSinceVersionSource = semanticVersion.BuildMetaData.CommitsSinceTag.Value;
                 semanticVersion.BuildMetaData.CommitsSinceTag = null; // why is this set to null ?