cleanup

Author: arturcic

src/GitVersion.LibGit2Sharp/Git/Branch.cs

@@ -6,10 +6,8 @@ namespace GitVersion
 {
     internal class Branch : IBranch
     {
-        private static readonly LambdaEqualityHelper<IBranch> equalityHelper =
-            new LambdaEqualityHelper<IBranch>(x => x.CanonicalName);
-        private static readonly LambdaKeyComparer<IBranch, string> comparerHelper =
-            new LambdaKeyComparer<IBranch, string>(x => x.CanonicalName);
+        private static readonly LambdaEqualityHelper<IBranch> equalityHelper = new(x => x.CanonicalName);
+        private static readonly LambdaKeyComparer<IBranch, string> comparerHelper = new(x => x.CanonicalName);
 
         private readonly LibGit2Sharp.Branch innerBranch;
 
@@ -18,9 +16,6 @@ internal Branch(LibGit2Sharp.Branch branch)
             innerBranch = branch;
         }
 
-        protected Branch()
-        {
-        }
         public int CompareTo(IBranch other) => comparerHelper.Compare(this, other);
         public override bool Equals(object obj) => Equals(obj as IBranch);
         public bool Equals(IBranch other) => equalityHelper.Equals(this, other);
@@ -53,7 +48,6 @@ public virtual ICommitCollection Commits
         {
             get
             {
-
                 var commits = innerBranch.Commits;
                 return commits is null ? null : new CommitCollection(commits);
             }

src/GitVersion.LibGit2Sharp/Git/BranchCollection.cs

@@ -9,10 +9,6 @@ internal class BranchCollection : IBranchCollection
         private readonly LibGit2Sharp.BranchCollection innerCollection;
         internal BranchCollection(LibGit2Sharp.BranchCollection collection) => innerCollection = collection;
 
-        protected BranchCollection()
-        {
-        }
-
         public virtual IEnumerator<IBranch> GetEnumerator()
         {
             return innerCollection.Select(branch => new Branch(branch)).GetEnumerator();

src/GitVersion.LibGit2Sharp/Git/Commit.cs

@@ -6,10 +6,8 @@ namespace GitVersion
 {
     internal class Commit : ICommit
     {
-        private static readonly LambdaEqualityHelper<ICommit> equalityHelper =
-            new LambdaEqualityHelper<ICommit>(x => x.Id);
-        private static readonly LambdaKeyComparer<ICommit, string> comparerHelper =
-            new LambdaKeyComparer<ICommit, string>(x => x.Sha);
+        private static readonly LambdaEqualityHelper<ICommit> equalityHelper = new(x => x.Id);
+        private static readonly LambdaKeyComparer<ICommit, string> comparerHelper = new(x => x.Sha);
 
         private readonly LibGit2Sharp.Commit innerObjectId;
 
@@ -18,10 +16,6 @@ internal Commit(LibGit2Sharp.Commit objectId)
             innerObjectId = objectId;
         }
 
-        protected Commit()
-        {
-        }
-
         public int CompareTo(ICommit other) => comparerHelper.Compare(this, other);
         public override bool Equals(object obj) => Equals(obj as ICommit);
         public bool Equals(ICommit other) => equalityHelper.Equals(this, other);

src/GitVersion.LibGit2Sharp/Git/CommitCollection.cs

@@ -11,10 +11,6 @@ internal class CommitCollection : ICommitCollection
         private readonly ICommitLog innerCollection;
         internal CommitCollection(ICommitLog collection) => innerCollection = collection;
 
-        protected CommitCollection()
-        {
-        }
-
         public virtual IEnumerator<ICommit> GetEnumerator()
         {
             return innerCollection.Select(commit => new Commit(commit)).GetEnumerator();

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -229,14 +229,14 @@ private void AddMissingRefSpecs(LibGit2Sharp.Remote remote)
 
         private static FetchOptions GetFetchOptions(AuthenticationInfo auth)
         {
-            return new FetchOptions
+            return new()
             {
                 CredentialsProvider = GetCredentialsProvider(auth)
             };
         }
         private static CloneOptions GetCloneOptions(AuthenticationInfo auth)
         {
-            return new CloneOptions
+            return new()
             {
                 Checkout = false,
                 CredentialsProvider = GetCredentialsProvider(auth)

src/GitVersion.LibGit2Sharp/Git/ObjectId.cs

@@ -4,10 +4,8 @@ namespace GitVersion
 {
     internal class ObjectId : IObjectId
     {
-        private static readonly LambdaEqualityHelper<IObjectId> equalityHelper =
-            new LambdaEqualityHelper<IObjectId>(x => x.Sha);
-        private static readonly LambdaKeyComparer<IObjectId, string> comparerHelper =
-            new LambdaKeyComparer<IObjectId, string>(x => x.Sha);
+        private static readonly LambdaEqualityHelper<IObjectId> equalityHelper = new(x => x.Sha);
+        private static readonly LambdaKeyComparer<IObjectId, string> comparerHelper = new(x => x.Sha);
 
         private readonly LibGit2Sharp.ObjectId innerObjectId;
         internal ObjectId(LibGit2Sharp.ObjectId objectId)

src/GitVersion.LibGit2Sharp/Git/Reference.cs

@@ -5,10 +5,8 @@ namespace GitVersion
 {
     internal class Reference : IReference
     {
-        private static readonly LambdaEqualityHelper<IReference> equalityHelper =
-            new LambdaEqualityHelper<IReference>(x => x.CanonicalName);
-        private static readonly LambdaKeyComparer<IReference, string> comparerHelper =
-            new LambdaKeyComparer<IReference, string>(x => x.CanonicalName);
+        private static readonly LambdaEqualityHelper<IReference> equalityHelper = new(x => x.CanonicalName);
+        private static readonly LambdaKeyComparer<IReference, string> comparerHelper = new(x => x.CanonicalName);
 
         internal readonly LibGit2Sharp.Reference innerReference;
         private DirectReference directReference => innerReference.ResolveToDirectReference();
@@ -18,10 +16,6 @@ internal Reference(LibGit2Sharp.Reference reference)
             innerReference = reference;
         }
 
-        protected Reference()
-        {
-        }
-
         public int CompareTo(IReference other) => comparerHelper.Compare(this, other);
         public override bool Equals(object obj) => Equals(obj as IReference);
         public bool Equals(IReference other) => equalityHelper.Equals(this, other);

src/GitVersion.LibGit2Sharp/Git/ReferenceCollection.cs

@@ -9,10 +9,6 @@ internal class ReferenceCollection : IReferenceCollection
         private readonly LibGit2Sharp.ReferenceCollection innerCollection;
         internal ReferenceCollection(LibGit2Sharp.ReferenceCollection collection) => innerCollection = collection;
 
-        protected ReferenceCollection()
-        {
-        }
-
         public virtual IEnumerator<IReference> GetEnumerator()
         {
             return innerCollection.Select(reference => new Reference(reference)).GetEnumerator();

src/GitVersion.LibGit2Sharp/Git/Remote.cs

@@ -5,10 +5,8 @@ namespace GitVersion
 {
     internal class Remote : IRemote
     {
-        private static readonly LambdaEqualityHelper<IRemote> equalityHelper =
-            new LambdaEqualityHelper<IRemote>(x => x.Name);
-        private static readonly LambdaKeyComparer<IRemote, string> comparerHelper =
-            new LambdaKeyComparer<IRemote, string>(x => x.Name);
+        private static readonly LambdaEqualityHelper<IRemote> equalityHelper = new(x => x.Name);
+        private static readonly LambdaKeyComparer<IRemote, string> comparerHelper = new(x => x.Name);
 
         private readonly LibGit2Sharp.Remote innerRemote;
 
@@ -17,10 +15,6 @@ internal Remote(LibGit2Sharp.Remote remote)
             innerRemote = remote;
         }
 
-        protected Remote()
-        {
-        }
-
         public int CompareTo(IRemote other) => comparerHelper.Compare(this, other);
         public override bool Equals(object obj) => Equals(obj as IRemote);
         public bool Equals(IRemote other) => equalityHelper.Equals(this, other);

src/GitVersion.LibGit2Sharp/Git/Tag.cs

@@ -5,21 +5,15 @@ namespace GitVersion
 {
     internal class Tag : ITag
     {
-        private static readonly LambdaEqualityHelper<ITag> equalityHelper =
-            new LambdaEqualityHelper<ITag>(x => x.CanonicalName);
-        private static readonly LambdaKeyComparer<ITag, string> comparerHelper =
-            new LambdaKeyComparer<ITag, string>(x => x.CanonicalName);
+        private static readonly LambdaEqualityHelper<ITag> equalityHelper = new(x => x.CanonicalName);
+        private static readonly LambdaKeyComparer<ITag, string> comparerHelper = new(x => x.CanonicalName);
 
         private readonly LibGit2Sharp.Tag innerTag;
         internal Tag(LibGit2Sharp.Tag tag)
         {
             innerTag = tag;
         }
 
-        protected Tag()
-        {
-        }
-
         public int CompareTo(ITag other) => comparerHelper.Compare(this, other);
         public override bool Equals(object obj) => Equals(obj as ITag);
         public bool Equals(ITag other) => equalityHelper.Equals(this, other);