(build) publish docker images to GitHubPackages and DockerHub

Author: arturcic

.github/workflows/ci.yml

@@ -269,9 +269,9 @@ jobs:
         name: nuget
         path: ${{ github.workspace }}/artifacts/packages/nuget
     -
-      name: '[Test Artifacts]'
+      name: '[Docker Build/Test/Publish]'
       shell: pwsh
-      run: dotnet run/docker.dll --target=Docker --docker_dotnetversion=${{ matrix.targetFramework }} --docker_distro=${{ matrix.distro }}
+      run: dotnet run/docker.dll --target=DockerPublish --docker_dotnetversion=${{ matrix.targetFramework }} --docker_distro=${{ matrix.distro }}
 
   publish:
     name: Publish

build/docker/BuildLifetime.cs

@@ -16,20 +16,16 @@ public override void Setup(BuildContext context)
 
             context.IsDockerOnLinux = context.DockerCustomCommand("info --format '{{.OSType}}'").First().Replace("'", "") == "linux";
 
-            var dockerRegistry = context.Argument("docker_registry", "github").ToLower();
             var dotnetVersion = context.Argument("docker_dotnetversion", "").ToLower();
             var dockerDistro = context.Argument("docker_distro", "").ToLower();
 
             var versions = string.IsNullOrWhiteSpace(dotnetVersion) ? Constants.VersionsToBuild : new[] { dotnetVersion };
             var distros = string.IsNullOrWhiteSpace(dockerDistro) ? Constants.DockerDistrosToBuild : new[] { dockerDistro };
 
-            context.DockerRegistryPrefix = dockerRegistry == "github" ? Constants.GitHubContainerRegistry : Constants.DockerHubRegistry;
             context.Images = from version in versions
                              from distro in distros
                              select new DockerImage(distro, version);
 
-            context.Credentials = Credentials.GetCredentials(context, dockerRegistry);
-
             context.StartGroup("Build Setup");
 
             LogBuildInformation(context);

build/docker/Tasks/Docker.cs

@@ -2,13 +2,27 @@
 using Cake.Common.Diagnostics;
 using Cake.Frosting;
 using Common.Utilities;
+using Docker.Utilities;
 
 namespace Docker.Tasks
 {
     [TaskName(nameof(DockerPublish))]
     [TaskDescription("Publish the docker images containing the GitVersion Tool")]
-    [IsDependentOn(typeof(DockerTest))]
+    [IsDependentOn(typeof(DockerPublishInternal))]
     public class DockerPublish : FrostingTask<BuildContext>
+    {
+        public override bool ShouldRun(BuildContext context)
+        {
+            var shouldRun = true;
+            shouldRun &= context.ShouldRun(context.IsGitHubActionsBuild, $"{nameof(DockerPublish)} works only on GitHub Actions.");
+            return shouldRun;
+        }
+    }
+
+    [TaskName(nameof(DockerPublishInternal))]
+    [TaskDescription("Publish the docker images containing the GitVersion Tool")]
+    [IsDependentOn(typeof(DockerTest))]
+    public class DockerPublishInternal : FrostingTask<BuildContext>
     {
         public override bool ShouldRun(BuildContext context)
         {
@@ -22,6 +36,16 @@ public override bool ShouldRun(BuildContext context)
 
         public override void Run(BuildContext context)
         {
+            DockerPublish(context, DockerRegistry.GitHub);
+            DockerPublish(context, DockerRegistry.DockerHub);
+        }
+        private static void DockerPublish(BuildContext context, DockerRegistry dockerRegistry)
+        {
+            context.Credentials = Credentials.GetCredentials(context, dockerRegistry);
+            context.DockerRegistryPrefix = dockerRegistry == DockerRegistry.GitHub
+                ? Constants.GitHubContainerRegistry
+                : Constants.DockerHubRegistry;
+
             context.Information($"Docker image prefix: {context.DockerRegistryPrefix}");
             var username = context.Credentials?.Docker?.UserName;
             if (string.IsNullOrEmpty(username))

build/docker/Tasks/DockerPublish.cs

@@ -1,21 +1,31 @@
 using Cake.Common;
 using Cake.Core;
+using Cake.Incubator.LoggingExtensions;
 using Common.Utilities;
 
 namespace Docker.Utilities
 {
+    public enum DockerRegistry
+    {
+        GitHub = 0,
+        DockerHub = 1
+    }
     public class Credentials
     {
         public DockerCredentials? Docker { get; private set; }
-        public static Credentials GetCredentials(ICakeContext context, string dockerRegistry) => new()
+        public static Credentials GetCredentials(ICakeContext context, DockerRegistry dockerRegistry) => new()
         {
-            Docker = dockerRegistry == "github"
-                ? new DockerCredentials(
-                    context.EnvironmentVariable("GITHUB_USERNAME"),
-                    context.EnvironmentVariable("GITHUB_TOKEN"))
-                : new DockerCredentials(
-                    context.EnvironmentVariable("DOCKER_USERNAME"),
-                    context.EnvironmentVariable("DOCKER_PASSWORD"))
+            Docker = dockerRegistry switch
+            {
+                DockerRegistry.GitHub =>
+                    new DockerCredentials(
+                        context.EnvironmentVariable("GITHUB_USERNAME"),
+                        context.EnvironmentVariable("GITHUB_TOKEN")),
+                _ =>
+                    new DockerCredentials(
+                        context.EnvironmentVariable("DOCKER_USERNAME"),
+                        context.EnvironmentVariable("DOCKER_PASSWORD"))
+            }
         };
     }
 }