Merge pull request #4762 from davidjenni/fix-diag-switch

Fix diag switch

Author: arturcic

src/GitVersion.App.Tests/ArgumentParserTests.cs

@@ -636,6 +636,21 @@ public void AllowshallowTrueWhenDefined()
         arguments.AllowShallow.ShouldBe(true);
     }
 
+    [Test]
+    public void DiagTrueWhenDefined()
+    {
+        var arguments = this.argumentParser.ParseArguments("-diag");
+        arguments.Diag.ShouldBe(true);
+    }
+
+    [Test]
+    public void DiagAndLogToConsoleIsNotIgnored()
+    {
+        var arguments = this.argumentParser.ParseArguments("-diag -l console");
+        arguments.Diag.ShouldBe(true);
+        arguments.LogFilePath.ShouldBe("console");
+    }
+
     [Test]
     public void OtherArgumentsCanBeParsedBeforeNofetch()
     {

src/GitVersion.App/ArgumentParser.cs

@@ -212,11 +212,7 @@ private static bool ParseSwitches(Arguments arguments, string? name, IReadOnlyLi
 
         if (name.IsSwitch("diag"))
         {
-            if (value?.IsTrue() != false)
-            {
-                arguments.Diag = true;
-            }
-
+            arguments.Diag = true;
             return true;
         }
 

src/GitVersion.App/ArgumentParserExtensions.cs

@@ -73,7 +73,7 @@ public bool IsSwitch(string switchName)
 
         public bool ArgumentRequiresValue(int argumentIndex)
         {
-            var booleanArguments = new[] { "updateassemblyinfo", "ensureassemblyinfo", "nofetch", "nonormalize", "nocache", "allowshallow" };
+            var booleanArguments = new[] { "updateassemblyinfo", "ensureassemblyinfo", "nofetch", "nonormalize", "nocache", "allowshallow", "diag" };
 
             var argumentMightRequireValue = !booleanArguments.Contains(singleArgument[1..], StringComparer.OrdinalIgnoreCase);