Skip to content

Commit 27ef709

Browse files
committed
ensures consistent date parsing
Uses `CultureInfo.InvariantCulture` for date parsing in tests to avoid locale-specific issues.
1 parent daf63ff commit 27ef709

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

src/GitVersion.Core.Tests/Extensions/StringFormatWithExtensionTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System.Globalization;
12
using GitVersion.Core.Tests.Helpers;
23
using GitVersion.Formatting;
34

@@ -261,7 +262,7 @@ public void FormatAssemblyInformationalVersionWithSemanticVersionCustomFormatted
261262
Sha = "commitSha",
262263
ShortSha = "commitShortSha",
263264
CommitsSinceVersionSource = 42,
264-
CommitDate = DateTimeOffset.Parse("2014-03-06 23:59:59Z")
265+
CommitDate = DateTimeOffset.Parse("2014-03-06 23:59:59Z", CultureInfo.InvariantCulture)
265266
}
266267
};
267268
const string target = "{Major}.{Minor}.{Patch}-{CommitsSinceVersionSource:0000}";

src/GitVersion.Core.Tests/Formatting/DateFormatterTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using GitVersion.Formatting;
1+
using System.Globalization;
2+
using GitVersion.Formatting;
23

34
namespace GitVersion.Tests.Formatting;
45

@@ -21,7 +22,7 @@ public void TryFormat_NullValue_ReturnsFalse()
2122
[TestCase("2021-01-01T12:00:00Z", "yyyy-MM-ddTHH:mm:ssZ", "2021-01-01T12:00:00Z")]
2223
public void TryFormat_ValidDateFormats_ReturnsExpectedResult(string input, string format, string expected)
2324
{
24-
var date = DateTime.Parse(input);
25+
var date = DateTime.Parse(input, CultureInfo.InvariantCulture);
2526
var sut = new DateFormatter();
2627
var result = sut.TryFormat(date, format, out var formatted);
2728
result.ShouldBeTrue();

src/GitVersion.Core.Tests/Formatting/ValueFormatterTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void TryFormat_Number_UsesNumericFormatter()
3333
[Test]
3434
public void TryFormat_Date_UsesDateFormatter()
3535
{
36-
var date = new DateTime(2023, 12, 25);
36+
var date = new DateTime(2023, 12, 25, 0, 0, 0, DateTimeKind.Utc);
3737
var result = ValueFormatter.Default.TryFormat(date, "yyyy-MM-dd", out var formatted);
3838
result.ShouldBeTrue();
3939
formatted.ShouldBe("2023-12-25");
@@ -42,7 +42,7 @@ public void TryFormat_Date_UsesDateFormatter()
4242
[Test]
4343
public void TryFormat_FormattableObject_UsesFormattableFormatter()
4444
{
45-
var value = 123.456m;
45+
const decimal value = 123.456m;
4646
var result = ValueFormatter.Default.TryFormat(value, "C", out var formatted);
4747
result.ShouldBeTrue();
4848
formatted.ShouldBe("¤123.46");
@@ -106,7 +106,7 @@ public void Formatters_ExecuteInPriorityOrder()
106106
formatted.ShouldBe("CUSTOM:test");
107107
}
108108

109-
private class TestFormatter : IValueFormatter
109+
private sealed class TestFormatter : IValueFormatter
110110
{
111111
public int Priority { get; init; }
112112

src/GitVersion.Core.Tests/VersionCalculation/VariableProviderTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System.Globalization;
12
using GitVersion.Configuration;
23
using GitVersion.Core.Tests.Helpers;
34
using GitVersion.Git;
@@ -301,7 +302,7 @@ public void Format_Allows_CSharp_FormatStrings()
301302
Sha = "commitSha",
302303
ShortSha = "commitShortSha",
303304
CommitsSinceVersionSource = 42,
304-
CommitDate = DateTimeOffset.Parse("2014-03-06 23:59:59Z")
305+
CommitDate = DateTimeOffset.Parse("2014-03-06 23:59:59Z", CultureInfo.InvariantCulture)
305306
}
306307
};
307308

0 commit comments

Comments
 (0)