Use Shouldly instead of NUnit assert, for #313

Author: serra

src/GitVersionCore.Tests/BuildServers/EnvironmentVariableJenkinsTests.cs

@@ -1,6 +1,7 @@
 using System;
 using GitVersion;
 using NUnit.Framework;
+using Shouldly;
 
 [TestFixture]
 public class EnvironmentVariableJenkinsTests
@@ -22,14 +23,14 @@ public void CanApplyCurrentContextWhenEnvironmentVariableIsSet()
     {
         SetEnvironmentVariableForDetection();
         var j = new Jenkins();
-        Assert.True(j.CanApplyToCurrentContext());   
+        j.CanApplyToCurrentContext().ShouldBe(true);
     }
 
     [Test]
     public void CanNotApplyCurrentContextWhenEnvironmentVariableIsNotSet()
     {
         ClearEnvironmentVariableForDetection();
         var j = new Jenkins();
-        Assert.False(j.CanApplyToCurrentContext());  
+        j.CanApplyToCurrentContext().ShouldBe(false);  
     }
 }

src/GitVersionCore.Tests/BuildServers/JenkinsMessageGenerationTests.cs

@@ -12,17 +12,16 @@ public class JenkinsMessageGenerationTests
     public void GenerateSetVersionMessageReturnsVersionAsIs_AlthoughThisIsNotUsedByJenkins()
     {
         var j = new Jenkins();
-        var v = j.GenerateSetVersionMessage("0.0.0-Beta4.7");
-        Assert.AreEqual                    ("0.0.0-Beta4.7", v);
+        j.GenerateSetVersionMessage("0.0.0-Beta4.7").ShouldBe("0.0.0-Beta4.7");
     }
 
     [Test]
     public void GenerateMessageTest()
     {
         var j = new Jenkins();
-        var actual = j.GenerateSetParameterMessage("name", "value");
-        Assert.AreEqual(1, actual.Length);
-        Assert.AreEqual("GitVersion_name=value", actual[0]);
+        var generatedParameterMessages = j.GenerateSetParameterMessage("name", "value");
+        generatedParameterMessages.Length.ShouldBe(1);
+        generatedParameterMessages[0].ShouldBe("GitVersion_name=value");
     }
 
     [Test, Explicit]
@@ -63,11 +62,11 @@ static void AssertVariablesAreWrittenToFile(string f)
 
         writes[1].ShouldBe("1.2.3-beta.1+5");
 
-        Assert.True(File.Exists(f));
+        File.Exists(f).ShouldBe(true);
 
         var props = File.ReadAllText(f);
 
-        StringAssert.Contains("GitVersion_Major=1", props);
-        StringAssert.Contains("GitVersion_Minor=2", props);
+        props.ShouldContain("GitVersion_Major=1");
+        props.ShouldContain("GitVersion_Minor=2");
     }
 }