fixes potential resource leaks

Fixes potential resource leaks by properly disposing of `Repository` instances.

Author: arturcic

build/CI.slnx

@@ -43,6 +43,7 @@
     <File Path="../.github/workflows/homebrew.yml" />
     <File Path="../.github/workflows/mkdocs.yml" />
     <File Path="../.github/workflows/new-cli.yml" />
+    <File Path="../.github/workflows/public-api.yml" />
     <File Path="../.github/workflows/release.yml" />
     <File Path="../.github/workflows/stale.yml" />
     <File Path="../.github/workflows/winget.yml" />

src/GitVersion.Core/Configuration/IgnoreConfigurationExtensions.cs

@@ -22,5 +22,5 @@ public static IEnumerable<ICommit> Filter(this IIgnoreConfiguration ignore, ICom
     }
 
     private static bool ShouldBeIgnored(ICommit commit, IIgnoreConfiguration ignore)
-        => !ignore.ToFilters().Any(filter => filter.Exclude(commit, out var _));
+        => !ignore.ToFilters().Any(filter => filter.Exclude(commit, out _));
 }

src/GitVersion.Core/VersionCalculation/ShaVersionFilter.cs

@@ -30,7 +30,9 @@ public bool Exclude(ICommit? commit, [NotNullWhen(true)] out string? reason)
 
         if (commit == null
             || !this.shaList.Any(sha => commit.Sha.StartsWith(sha, StringComparison.OrdinalIgnoreCase)))
+        {
             return false;
+        }
 
         reason = $"Sha {commit} was ignored due to commit having been excluded by configuration";
         return true;

src/GitVersion.LibGit2Sharp/Git/GitRepository.cs

@@ -69,7 +69,9 @@ public int UncommittedChangesCount()
 
     public void Dispose()
     {
-        if (this.repositoryLazy is { IsValueCreated: true }) RepositoryInstance.Dispose();
+        if (this.repositoryLazy is not { IsValueCreated: true }) return;
+        RepositoryInstance.Dispose();
+        this.repositoryLazy = null;
     }
 
     private int GetUncommittedChangesCountInternal()

src/GitVersion.LibGit2Sharp/Git/GitRepositoryInfo.cs

@@ -89,7 +89,8 @@ private string GetProjectRootDirectory()
         if (gitDirectory.IsNullOrEmpty())
             throw new DirectoryNotFoundException("Cannot find the .git directory");
 
-        return new Repository(gitDirectory).Info.WorkingDirectory;
+        using var repo = new Repository(gitDirectory);
+        return repo.Info.WorkingDirectory;
     }
 
     private string? GetGitRootPath()
@@ -104,7 +105,7 @@ private static bool GitRepoHasMatchingRemote(string possiblePath, string targetU
     {
         try
         {
-            var gitRepository = new Repository(possiblePath);
+            using var gitRepository = new Repository(possiblePath);
             return gitRepository.Network.Remotes.Any(r => r.Url == targetUrl);
         }
         catch (Exception)