Rename unit test method name and remove unnecessary comments in variable provider

Author: HHobeck

src/GitVersion.Core.Tests/IntegrationTests/OtherBranchScenarios.cs

@@ -7,8 +7,11 @@ namespace GitVersion.Core.Tests.IntegrationTests;
 [TestFixture]
 public class OtherBranchScenarios : TestBase
 {
+    /// <summary>
+    /// https://github.com/GitTools/GitVersion/issues/2340
+    /// </summary>
     [Test]
-    public void __Just_A_Test__()
+    public void ShouldOnlyConsiderTagsMatchingOfCurrentBranch()
     {
         var configuration = GitFlowConfigurationBuilder.New
             .WithBranch("develop", builder => builder.WithLabel("snapshot"))

src/GitVersion.Core/VersionCalculation/VariableProvider.cs

@@ -25,8 +25,6 @@ public VersionVariables GetVariablesFor(
             // Continuous Deployment always requires a pre-release tag unless the commit is tagged
             if (!semanticVersion.PreReleaseTag.HasTag())
             {
-                // TODO: Why do we manipulating the semantic version here in the VariableProvider? The method name is GET not MANIPULATE.
-                // What is about the separation of concern and single-responsibility principle?
                 preReleaseTagName = configuration.GetBranchSpecificLabel(semanticVersion.BuildMetaData.Branch, null);
                 if (preReleaseTagName.IsNullOrEmpty())
                 {
@@ -43,16 +41,12 @@ public VersionVariables GetVariablesFor(
             var numberGroup = match.Groups["number"];
             if (numberGroup.Success)
             {
-                // TODO: Why do we manipulating the semantic version here in the VariableProvider? The method name is GET not MANIPULATE.
-                // What is about the separation of concern and single-responsibility principle?
                 preReleaseTagName += numberGroup.Value;
             }
         }
 
         if (isContinuousDeploymentMode || appendTagNumberPattern || configuration.VersioningMode == VersioningMode.Mainline)
         {
-            // TODO: Why do we manipulating the semantic version here in the VariableProvider? The method name is GET not MANIPULATE.
-            // What is about the separation of concern and single-responsibility principle?
             semanticVersion = PromoteNumberOfCommitsToTagNumber(semanticVersion, preReleaseTagName);
         }
         else