(ci) - redefine the IsStableRelease, IsTaggedPreRelease and IsInternalPreRelease

Author: arturcic

build/build/Tasks/Test/PublishCoverage.cs

@@ -12,7 +12,7 @@ public override bool ShouldRun(BuildContext context)
     {
         var shouldRun = true;
         shouldRun &= context.ShouldRun(context.IsOnWindows, $"{nameof(PublishCoverage)} works only on Windows agents.");
-        shouldRun &= context.ShouldRun(context.IsOnMainOrSupportBranchOriginalRepo, $"{nameof(PublishCoverage)} works only for on main or release branch original repository.");
+        shouldRun &= context.ShouldRun(context.IsReleaseBranchOriginalRepo, $"{nameof(PublishCoverage)} works only for main or release branch, original repository.");
 
         return shouldRun;
     }

build/common/Utilities/BuildContextBase.cs

@@ -19,7 +19,8 @@ protected BuildContextBase(ICakeContext context) : base(context)
     public bool IsOnWindows { get; set; }
     public bool IsOnLinux { get; set; }
     public bool IsOnMacOS { get; set; }
-    public bool IsOnMainOrSupportBranchOriginalRepo => !IsLocalBuild && IsOriginalRepo && (IsMainBranch || IsSupportBranch) && !IsPullRequest;
-    public bool IsStableRelease => IsOnMainOrSupportBranchOriginalRepo && IsTagged && Version?.IsPreRelease == false;
-    public bool IsPreRelease => IsOnMainOrSupportBranchOriginalRepo && !IsTagged;
+    public bool IsReleaseBranchOriginalRepo => !IsLocalBuild && IsOriginalRepo && (IsMainBranch || IsSupportBranch) && !IsPullRequest;
+    public bool IsStableRelease => IsReleaseBranchOriginalRepo && IsTagged && Version?.IsPreRelease == false;
+    public bool IsTaggedPreRelease => IsReleaseBranchOriginalRepo && IsTagged && Version?.IsPreRelease == true;
+    public bool IsInternalPreRelease => IsReleaseBranchOriginalRepo && IsGitHubActionsBuild;
 }

build/docker/Tasks/DockerManifest.cs

@@ -30,11 +30,11 @@ public override bool ShouldRun(BuildContext context)
 
         if (context.DockerRegistry == DockerRegistry.GitHub)
         {
-            shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsPreRelease, $"{nameof(DockerPublish)} to GitHub Package Registry works only for releases.");
+            shouldRun &= context.ShouldRun(context.IsInternalPreRelease, $"{nameof(DockerPublish)} to GitHub Package Registry works only internal releases.");
         }
         if (context.DockerRegistry == DockerRegistry.DockerHub)
         {
-            shouldRun &= context.ShouldRun(context.IsStableRelease, $"{nameof(DockerPublish)} DockerHub works only for tagged releases.");
+            shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsTaggedPreRelease, $"{nameof(DockerPublish)} to DockerHub works only for tagged releases.");
         }
 
         return shouldRun;

build/docker/Tasks/DockerPublish.cs

@@ -31,11 +31,11 @@ public override bool ShouldRun(BuildContext context)
         shouldRun &= context.ShouldRun(context.IsDockerOnLinux, $"{nameof(DockerPublish)} works only on Docker on Linux agents.");
         if (context.DockerRegistry == DockerRegistry.GitHub)
         {
-            shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsPreRelease, $"{nameof(DockerPublish)} to GitHub Package Registry works only for releases.");
+            shouldRun &= context.ShouldRun(context.IsInternalPreRelease, $"{nameof(DockerPublish)} to GitHub Package Registry works only for internal releases.");
         }
         if (context.DockerRegistry == DockerRegistry.DockerHub)
         {
-            shouldRun &= context.ShouldRun(context.IsStableRelease, $"{nameof(DockerPublish)} DockerHub works only for tagged releases.");
+            shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsTaggedPreRelease, $"{nameof(DockerPublish)} to DockerHub works only for tagged releases.");
         }
 
         return shouldRun;

build/publish/Tasks/PublishChocolatey.cs

@@ -20,7 +20,7 @@ public override bool ShouldRun(BuildContext context)
         var shouldRun = true;
         shouldRun &= context.ShouldRun(context.IsGitHubActionsBuild, $"{nameof(PublishChocolatey)} works only on GitHub Actions.");
         shouldRun &= context.ShouldRun(context.IsOnWindows, $"{nameof(PublishChocolatey)} works only on windows.");
-        shouldRun &= context.ShouldRun(context.IsStableRelease, $"{nameof(PublishChocolatey)} works only for stable releases.");
+        shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsTaggedPreRelease, $"{nameof(PublishChocolatey)} works only for tagged releases.");
 
         return shouldRun;
     }

build/publish/Tasks/PublishNuget.cs

@@ -18,15 +18,15 @@ public override bool ShouldRun(BuildContext context)
     {
         var shouldRun = true;
         shouldRun &= context.ShouldRun(context.IsGitHubActionsBuild, $"{nameof(PublishNuget)} works only on GitHub Actions.");
-        shouldRun &= context.ShouldRun(context.IsPreRelease || context.IsStableRelease, $"{nameof(PublishNuget)} works only for releases.");
+        shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsTaggedPreRelease || context.IsInternalPreRelease, $"{nameof(PublishNuget)} works only for releases.");
 
         return shouldRun;
     }
 
     public override void Run(BuildContext context)
     {
         // publish to github packages for commits on main and on original repo
-        if (context is { IsGitHubActionsBuild: true, IsOnMainOrSupportBranchOriginalRepo: true })
+        if (context.IsInternalPreRelease)
         {
             var apiKey = context.Credentials?.GitHub?.Token;
             if (string.IsNullOrEmpty(apiKey))
@@ -35,8 +35,8 @@ public override void Run(BuildContext context)
             }
             PublishToNugetRepo(context, apiKey, Constants.GithubPackagesUrl);
         }
-        // publish to nuget.org for stable releases
-        if (context.IsStableRelease)
+        // publish to nuget.org for tagged releases
+        if (context.IsStableRelease || context.IsTaggedPreRelease)
         {
             var apiKey = context.Credentials?.Nuget?.ApiKey;
             if (string.IsNullOrEmpty(apiKey))

build/release/Tasks/PublishRelease.cs

@@ -20,7 +20,7 @@ public override bool ShouldRun(BuildContext context)
     {
         var shouldRun = true;
         shouldRun &= context.ShouldRun(context.IsGitHubActionsBuild, $"{nameof(PublishRelease)} works only on GitHub Actions.");
-        shouldRun &= context.ShouldRun(context.IsStableRelease, $"{nameof(PublishRelease)} works only for releases.");
+        shouldRun &= context.ShouldRun(context.IsStableRelease || context.IsTaggedPreRelease, $"{nameof(PublishRelease)} works only for tagged releases.");
 
         return shouldRun;
     }