remove concept of releasedate from the core

Author: SimonCropp

GitVersionCore.Tests/InformationalVersionBuilderTests.cs

@@ -25,7 +25,7 @@ public void ValidateInformationalVersionBuilder(BranchType branchType, string br
             Minor = minor,
             Patch = patch,
             PreReleaseTag = tag,
-            BuildMetaData = new SemanticVersionBuildMetaData(suffix, branchName, new ReleaseDate(),sha,DateTimeOffset.MinValue),
+            BuildMetaData = new SemanticVersionBuildMetaData(suffix, branchName,sha,DateTimeOffset.MinValue),
         };
         var informationalVersion = semanticVersion.ToString("i");
 

GitVersionCore.Tests/JsonVersionBuilderTests.cs

@@ -15,12 +15,7 @@ public void Json()
                 Minor = 2,
                 Patch = 3,
                 PreReleaseTag = "unstable4",
-                BuildMetaData = new SemanticVersionBuildMetaData(5, "feature1",
-                    new ReleaseDate
-                    {
-                        OriginalCommitSha = "originalCommitSha",
-                        OriginalDate = DateTimeOffset.Parse("2014-03-01 00:00:01Z"),
-                    }, "commitSha",DateTimeOffset.Parse("2014-03-06 23:59:59Z"))
+                BuildMetaData = new SemanticVersionBuildMetaData(5, "feature1", "commitSha",DateTimeOffset.Parse("2014-03-06 23:59:59Z"))
             };
         var variables = VariableProvider.GetVariablesFor(semanticVersion);
         var json = JsonOutputFormatter.ToJson(variables);

GitVersionCore.Tests/VariableProviderTests.cs

@@ -18,11 +18,6 @@ public void DevelopBranchFormatsSemVerForCiFeed()
             BuildMetaData = "5.Branch.develop"
         };
 
-        semVer.BuildMetaData.ReleaseDate = new ReleaseDate
-        {
-            OriginalCommitSha = "originalCommitSha",
-            OriginalDate = DateTimeOffset.Parse("2014-03-01 00:00:01Z"),
-        };
         semVer.BuildMetaData.Sha = "commitSha";
         semVer.BuildMetaData.CommitDate = DateTimeOffset.Parse("2014-03-06 23:59:59Z");
 

GitVersionCore/GitFlow/BranchFinders/DevelopBasedVersionFinderBase.cs

@@ -21,7 +21,6 @@ protected SemanticVersion FindVersion(
             var versionFromMaster = versionOnMasterFinder.Execute(context, context.CurrentCommit.Committer.When);
 
             var numberOfCommitsOnBranchSinceCommit = NumberOfCommitsOnBranchSinceCommit(context, ancestor);
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, 0);
             var preReleaseTag = context.CurrentBranch.Name
                 .TrimStart(branchType.ToString() + '-')
                 .TrimStart(branchType.ToString() + '/');
@@ -33,7 +32,7 @@ protected SemanticVersion FindVersion(
                 PreReleaseTag = preReleaseTag,
                 BuildMetaData = new SemanticVersionBuildMetaData(
                     numberOfCommitsOnBranchSinceCommit,
-                    context.CurrentBranch.Name, releaseDate, context.CurrentCommit.Sha, context.CurrentCommit.When())
+                    context.CurrentBranch.Name, context.CurrentCommit.Sha, context.CurrentCommit.When())
             };
 
             semanticVersion.OverrideVersionManuallyIfNeeded(context.Repository);

GitVersionCore/GitFlow/BranchFinders/DevelopVersionFinder.cs

@@ -21,14 +21,13 @@ public SemanticVersion FindVersion(GitVersionContext context)
             var c = context.Repository.Commits.QueryBy(f);
             var numberOfCommitsSinceRelease = c.Count();
 
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, tip, 0);
             var semanticVersion = new SemanticVersion
             {
                 Major = versionFromMaster.Major,
                 Minor = versionFromMaster.Minor + 1,
                 Patch = 0,
                 PreReleaseTag = "unstable" + numberOfCommitsSinceRelease,
-                BuildMetaData = new SemanticVersionBuildMetaData(numberOfCommitsSinceRelease, context.CurrentBranch.Name, releaseDate,tip.Sha,tip.When()),
+                BuildMetaData = new SemanticVersionBuildMetaData(numberOfCommitsSinceRelease, context.CurrentBranch.Name,tip.Sha,tip.When()),
             };
 
             semanticVersion.OverrideVersionManuallyIfNeeded(context.Repository);

GitVersionCore/GitFlow/BranchFinders/MasterVersionFinder.cs

@@ -11,7 +11,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
                 ShortVersion shortVersion;
                 if (ShortVersionParser.TryParse(tag.Name, out shortVersion))
                 {
-                    return BuildVersion(repository, tip, shortVersion);
+                    return BuildVersion(tip, shortVersion);
                 }
             }
 
@@ -20,7 +20,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             ShortVersion versionFromTip;
             if (MergeMessageParser.TryParse(tip, out versionFromTip))
             {
-                semanticVersion = BuildVersion(repository, tip, versionFromTip);
+                semanticVersion = BuildVersion(tip, versionFromTip);
             }
 
             if (semanticVersion == null || semanticVersion.IsEmpty())
@@ -31,15 +31,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             return semanticVersion;
         }
 
-        SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
+        SemanticVersion BuildVersion(Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);
             return new SemanticVersion
             {
                 Major = shortVersion.Major,
                 Minor = shortVersion.Minor,
                 Patch = shortVersion.Patch,
-                BuildMetaData = new SemanticVersionBuildMetaData(null, "master", releaseDate,tip.Sha,tip.When())
+                BuildMetaData = new SemanticVersionBuildMetaData(null, "master",tip.Sha,tip.When())
             };
         }
     }

GitVersionCore/GitFlow/BranchFinders/OptionallyTaggedBranchVersionFinderBase.cs

@@ -30,15 +30,14 @@ protected SemanticVersion FindVersion(
 
             var tagVersion = RetrieveMostRecentOptionalTagVersion(context.Repository, version, context.CurrentBranch.Commits.Take(nbHotfixCommits + 1));
 
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, version.Patch);
             var semanticVersion = new SemanticVersion
             {
                 Major = version.Major,
                 Minor = version.Minor,
                 Patch = version.Patch,
                 PreReleaseTag = version.PreReleaseTag,
                 BuildMetaData = new SemanticVersionBuildMetaData(
-                    nbHotfixCommits, context.CurrentBranch.Name, releaseDate, context.CurrentCommit.Sha, context.CurrentCommit.When())
+                    nbHotfixCommits, context.CurrentBranch.Name, context.CurrentCommit.Sha, context.CurrentCommit.When())
             };
 
             if (tagVersion != null)

GitVersionCore/GitFlow/BranchFinders/SupportVersionFinder.cs

@@ -11,7 +11,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             ShortVersion shortVersion;
             if (ShortVersionParser.TryParse(tag.Name, out shortVersion))
                 {
-                    return BuildVersion(repository, tip, shortVersion);
+                    return BuildVersion(tip, shortVersion);
                 }
             }
 
@@ -20,7 +20,7 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             ShortVersion versionFromTip;
             if (MergeMessageParser.TryParse(tip, out versionFromTip))
             {
-                semanticVersion = BuildVersion(repository, tip, versionFromTip);
+                semanticVersion = BuildVersion(tip, versionFromTip);
             }
 
             semanticVersion.OverrideVersionManuallyIfNeeded(repository);
@@ -33,15 +33,14 @@ public SemanticVersion FindVersion(IRepository repository, Commit tip)
             return semanticVersion;
         }
 
-        SemanticVersion BuildVersion(IRepository repository, Commit tip, ShortVersion shortVersion)
+        SemanticVersion BuildVersion(Commit tip, ShortVersion shortVersion)
         {
-            var releaseDate = ReleaseDateFinder.Execute(repository, tip, shortVersion.Patch);
             return new SemanticVersion
             {
                 Major = shortVersion.Major,
                 Minor = shortVersion.Minor,
                 Patch = shortVersion.Patch,
-                BuildMetaData = new SemanticVersionBuildMetaData(null, "support", releaseDate, tip.Sha,tip.When())
+                BuildMetaData = new SemanticVersionBuildMetaData(null, "support", tip.Sha,tip.When())
             };
         } 
     }

GitVersionCore/GitHubFlow/BuildNumberCalculator.cs

@@ -23,10 +23,8 @@ public SemanticVersion GetBuildNumber(GitVersionContext context)
             var commitsSinceLastRelease = NumberOfCommitsOnBranchSinceCommit(context, commit);
             var semanticVersion = nextSemverCalculator.NextVersion();
 
-            var releaseDate = ReleaseDateFinder.Execute(context.Repository, context.CurrentCommit, semanticVersion.Patch);
-
             // TODO Need a way of setting this in a cross cutting way
-            semanticVersion.BuildMetaData = new SemanticVersionBuildMetaData(commitsSinceLastRelease, context.CurrentBranch.Name, releaseDate, context.CurrentCommit.Sha, context.CurrentCommit.When());
+            semanticVersion.BuildMetaData = new SemanticVersionBuildMetaData(commitsSinceLastRelease, context.CurrentBranch.Name, context.CurrentCommit.Sha, context.CurrentCommit.When());
             if (context.CurrentBranch.IsPullRequest())
             {
                 EnsurePullBranchShareACommonAncestorWithMaster(gitRepo, gitRepo.Head);

GitVersionCore/GitVersionCore.csproj

@@ -103,8 +103,6 @@
     <Compile Include="OutputVariables\CiFeedFormatter.cs" />
     <Compile Include="OutputVariables\VariableProvider.cs" />
     <Compile Include="AssemblyInfo.cs" />
-    <Compile Include="ReleaseDate.cs" />
-    <Compile Include="ReleaseDateFinder.cs" />
     <Compile Include="RepositoryLoader.cs" />
     <Compile Include="SearchPath.cs" />
     <Compile Include="SemanticVersion.cs" />