Skip to content

Commit 37dc680

Browse files
committed
Add null check to Tag
1 parent e9c93b2 commit 37dc680

File tree

1 file changed

+8
-6
lines changed
  • src/GitVersion.LibGit2Sharp/Git

1 file changed

+8
-6
lines changed

src/GitVersion.LibGit2Sharp/Git/Tag.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using GitVersion.Extensions;
12
using GitVersion.Helpers;
23
using LibGit2Sharp;
34

@@ -7,20 +8,17 @@ internal sealed class Tag : ITag
78
{
89
private static readonly LambdaEqualityHelper<ITag> equalityHelper = new(x => x.Name.Canonical);
910
private static readonly LambdaKeyComparer<ITag, string> comparerHelper = new(x => x.Name.Canonical);
10-
1111
private readonly LibGit2Sharp.Tag innerTag;
12+
1213
internal Tag(LibGit2Sharp.Tag tag)
1314
{
14-
this.innerTag = tag;
15+
this.innerTag = tag.NotNull();
1516
Name = new ReferenceName(this.innerTag.CanonicalName);
1617
}
17-
public ReferenceName Name { get; }
1818

19+
public ReferenceName Name { get; }
1920
public int CompareTo(ITag other) => comparerHelper.Compare(this, other);
2021
public bool Equals(ITag? other) => equalityHelper.Equals(this, other);
21-
public override bool Equals(object obj) => Equals((obj as ITag));
22-
public override int GetHashCode() => equalityHelper.GetHashCode(this);
23-
public override string ToString() => Name.ToString();
2422
public string? TargetSha => this.innerTag.Target.Sha;
2523

2624
public ICommit? PeeledTargetCommit()
@@ -34,4 +32,8 @@ internal Tag(LibGit2Sharp.Tag tag)
3432

3533
return target is LibGit2Sharp.Commit commit ? new Commit(commit) : null;
3634
}
35+
36+
public override bool Equals(object obj) => Equals((obj as ITag));
37+
public override int GetHashCode() => equalityHelper.GetHashCode(this);
38+
public override string ToString() => Name.ToString();
3739
}

0 commit comments

Comments
 (0)